Skip to content

Worker: Prefer to bind to non-link-local addresses, if possible #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DilumAluthge wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Worker: Prefer to bind to non-link-local addresses, if possible #76

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a637ba5
Worker: Bind to the first non-link-local IPv4 address
DilumAluthge Oct 24, 2026
482d74b
Re-do the conflict resolution, but this time stay more faithful to th…
DilumAluthge Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions src/cluster.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1656,6 +1656,38 @@ function terminate_all_workers()
end
end

function possible_bind_interfaces()
# We prefer IPv4 over IPv6.
#
# We also prefer non-link-local over link-local.
# (This is because on HPC clusters, link-local addresses are usually not
# usable for communication between compute nodes.
#
# Therefore, our order of preference is:
# 1. Non-link-local IPv4
# 2. Non-link-local IPv6
# 3. Link-local IPv4
# 4. Link-local IPv6
interfaces = _get_interfaces()
ipv4_nonlinklocal = filter(i -> !islinklocaladdr(i.ip) && i.ip isa IPv4, interfaces) # non-link-local IPv4
ipv6_nonlinklocal = filter(i -> !islinklocaladdr(i.ip) && i.ip isa IPv6, interfaces) # non-link-local IPv6
ipv4 = filter(i -> i.ip isa IPv4, interfaces) # IPv4
ipv6 = filter(i -> i.ip isa IPv6, interfaces) # IPv6
if !isempty(ipv4_nonlinklocal)
return ipv4_nonlinklocal
end
if !isempty(ipv6_nonlinklocal)
return ipv6_nonlinklocal
end
if !isempty(ipv4)
return ipv4
end
if !isempty(ipv6)
return ipv6
end
return Interface[]
end

# initialize the local proc network address / port
function init_bind_addr()
opts = JLOptions()
Expand All @@ -1677,12 +1709,7 @@ function init_bind_addr()
end
end
else
interfaces = _get_interfaces(IPv4)
if isempty(interfaces)
# Include IPv6 interfaces if there are no IPv4 ones

@DilumAluthge DilumAluthge Oct 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is now handled in choose_bind_addr()

interfaces = _get_interfaces()
end

interfaces = possible_bind_interfaces()
if isempty(interfaces)
# All networking is unavailable, initialize bind_addr to the loopback address.
# An exception will be raised later if even that is unavailable.
Expand Down
Loading