Skip to content

Worker: Prefer to bind to non-link-local addresses, if possible - #76

Draft
DilumAluthge wants to merge 2 commits into
masterfrom
dpa/forward-port-distributed-137
Draft

DilumAluthge wants to merge 2 commits into
masterfrom
dpa/forward-port-distributed-137

Conversation

@DilumAluthge

@DilumAluthge DilumAluthge commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

This started as a forward-port of JuliaLang/Distributed.jl#137 (cherry picked from commit JuliaLang/Distributed.jl@3679026).

And then I added some stuff to make it more faithful to the way DistributedNext#master currently does things.

Comment thread src/cluster.jl
else
interfaces = _get_interfaces(IPv4)
if isempty(interfaces)
# Include IPv6 interfaces if there are no IPv4 ones

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is now handled in choose_bind_addr()

@DilumAluthge
DilumAluthge removed the request for review from JamesWrigley October 24, 2026 04:58
@DilumAluthge

Copy link
Copy Markdown
Member Author

Hmmm. I need to tweak this a bit.

@DilumAluthge
DilumAluthge marked this pull request as draft October 24, 2026 04:58
@DilumAluthge DilumAluthge changed the title Worker: Bind to the first non-link-local IPv4 address Worker: Prefer to bind to non-link-local addresses, if possible Oct 24, 2026
@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.54%. Comparing base (52a81e1) to head (482d74b).

Files with missing lines Patch % Lines
src/cluster.jl 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   88.84%   88.54%   -0.31%     
==========================================
  Files          13       13              
  Lines        2277     2295      +18     
==========================================
+ Hits         2023     2032       +9     
- Misses        254      263       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This is a cherry-pick of JuliaLang/Distributed.jl#137

(cherry picked from commit 3679026d7b510befdedfa8c6497e3cb032f9cea1)
@DilumAluthge
DilumAluthge force-pushed the dpa/forward-port-distributed-137 branch from e7c48f2 to 482d74b Compare October 25, 2026 01:23
@DilumAluthge

Copy link
Copy Markdown
Member Author

The JET CI failure will be fixed by the stack of #77 plus #78.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant