Repository navigation
ifc: ceiling in pieces takes the area of its first top-face piece (RE-486) - #249
Merged
Merged
Conversation
…-486) Port rvt-rs RE-486 (#1209): where a ceiling has no computed host area, GrossCeilingArea is the piece holding its first top face (grouped by SourceFace/MeshMarker within its node, bottom piece within 0.1%) instead of the whole upper surface. Sketch area and single-piece behavior unchanged. Tests: CoveringFirstPieceTests; BaseQuantities suites green.
…nected pieces Review #249: TopSurfaceArea admitted any non-vertical face, so a closed sloped solid classified as pieces and shrank GrossCeilingArea. Require horizontal faces at one height per side. Group faces into connected components by shared vertices instead of serialized SourceFace handles, and search every underside piece for the single same-area counterpart at the top piece footprint. Caller-level regression tests through CoveringQuantitiesCurrent for sloped (whole surface) and two-piece (first piece) solids without a host area.
Recheck #249: with a sloped first top face followed by horizontal pieces, the rule picked the later 100 ft2 part (9.29 m2) instead of keeping the whole 436.80 ft2 (40.58 m2). The piece rule now applies only when the first top face itself is horizontal, per RE-486; otherwise the whole upper surface stays. Caller-level regression test covers sloped-first with later horizontal pieces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port rvt-rs RE-486 (#1209, changelog.d/fixed/1209-ceiling-pieces-gross-area.md): where a ceiling has no computed host area, GrossCeilingArea is the piece holding its first top face instead of the whole upper surface.\n\n- Faces grouped by serialized SourceFace/MeshMarker within their geometry node (as SurfaceAreaCurrent groups them); the piece is the group of the first top face in serialized order.\n- Applied only with no sketch area, more than one top piece, and a bottom piece of the same area within 0.1% (the saved-mesh RE-480/RE-486 guard); otherwise the whole upper surface stands as before.\n- Sketch-area and single-piece behavior unchanged (284 BaseQuantities tests green + 3 new CoveringFirstPieceTests).\n\nSource: https://github.com/DrunkOnJava/rvt-rs (RE-486, reports/element-framing/RE-486-ceiling-pieces-first-face-gross-area.md). No Autodesk code.