Skip to content

print: stop a joined wall end flat at the partner near face - #252

Merged
mahach666 merged 3 commits into
mainfrom
feat/plan-wall-join-cutback
Nov 16, 2026
Merged

mahach666 merged 3 commits into
mainfrom
feat/plan-wall-join-cutback

Conversation

@mahach666

Copy link
Copy Markdown
Collaborator

Port rvt-rs #1474 / RE-488 to PlanPrinter.CollectLevel (plan drawing; the IFC path already draws true BRep joins).\n\n- A butt join (JoinType 0, m_wallJoinType) to another wall of the same level cuts back the overshoot past the partner's near face; orthogonal joins only, only shortening (never extension), at most to a stub of the wall's own width.\n- Mutual end-to-end L corners (partner names this wall back at an end), mitre joins, roof-joined walls, partners off the level or without a line, and ambiguous ends (no single butt join) keep the stored location line.\n- rvt-rs's flat stop additionally requires the join step's m_omittedTarget, which the 2020-2025 schemas have no field for (verified against the files' own Formats/Latest: JoinEndGStep 2256 has 14 fields, no omitted target); that gate is future work with 2024+ fixtures.\n- Docs: docs/printing.md, CHANGELOG (keep both entries on merge if it conflicts with #249's entry at the same anchor). Tests: PlanWallJoinCutbackTests (5 synthetic T/L/mitre/roof-joined/start-end); print suites green on net8/net10; fixture check on the 2022/2025 projects: every joined end there is a mutual L corner, so their printed plans are byte-unchanged in walls.\n\nNo Autodesk code.

Port rvt-rs #1474 / RE-488 to PlanPrinter.CollectLevel: a butt join (JoinType 0) to another wall of the level cuts back the overshoot past the partner near face. Orthogonal joins only; mutual end-to-end L corners, mitre joins, roof-joined walls and ambiguous/off-level ends keep the stored line; only shortening, never extension. Tests: PlanWallJoinCutbackTests (5 synthetic); fixture check on 2022/2025 projects shows every joined end there is a mutual L corner, so their plans are unchanged.
Review #252: an end past the partner axis kept the far face (end stayed at 3050 instead of 2900) and starts moved to the axis (3000) instead of the face (3100). Choose the near face from the retained wall side (direction sign per end) and solve the +u displacement with per-end overshoot (end shortens on -t, start on +t). Offset tests cover both sides of the axis for starts and ends.
Resolve CHANGELOG.md conflict by preserving the ceiling-area and wall-join entries.
@mahach666
mahach666 merged commit 66a9fae into main Nov 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant