Repository navigation
print: stop a joined wall end flat at the partner near face - #252
Merged
Merged
Conversation
Port rvt-rs #1474 / RE-488 to PlanPrinter.CollectLevel: a butt join (JoinType 0) to another wall of the level cuts back the overshoot past the partner near face. Orthogonal joins only; mutual end-to-end L corners, mitre joins, roof-joined walls and ambiguous/off-level ends keep the stored line; only shortening, never extension. Tests: PlanWallJoinCutbackTests (5 synthetic); fixture check on 2022/2025 projects shows every joined end there is a mutual L corner, so their plans are unchanged.
Review #252: an end past the partner axis kept the far face (end stayed at 3050 instead of 2900) and starts moved to the axis (3000) instead of the face (3100). Choose the near face from the retained wall side (direction sign per end) and solve the +u displacement with per-end overshoot (end shortens on -t, start on +t). Offset tests cover both sides of the axis for starts and ends.
Resolve CHANGELOG.md conflict by preserving the ceiling-area and wall-join entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port rvt-rs #1474 / RE-488 to PlanPrinter.CollectLevel (plan drawing; the IFC path already draws true BRep joins).\n\n- A butt join (JoinType 0, m_wallJoinType) to another wall of the same level cuts back the overshoot past the partner's near face; orthogonal joins only, only shortening (never extension), at most to a stub of the wall's own width.\n- Mutual end-to-end L corners (partner names this wall back at an end), mitre joins, roof-joined walls, partners off the level or without a line, and ambiguous ends (no single butt join) keep the stored location line.\n- rvt-rs's flat stop additionally requires the join step's m_omittedTarget, which the 2020-2025 schemas have no field for (verified against the files' own Formats/Latest: JoinEndGStep 2256 has 14 fields, no omitted target); that gate is future work with 2024+ fixtures.\n- Docs: docs/printing.md, CHANGELOG (keep both entries on merge if it conflicts with #249's entry at the same anchor). Tests: PlanWallJoinCutbackTests (5 synthetic T/L/mitre/roof-joined/start-end); print suites green on net8/net10; fixture check on the 2022/2025 projects: every joined end there is a mutual L corner, so their printed plans are byte-unchanged in walls.\n\nNo Autodesk code.