Repository navigation
Conversation
…order, streaming binary and bounded lines
mahach666
force-pushed
the
feature/issue-25-las-reader
branch
from
November 17, 2026 15:02
d08536a to
479c49d
Compare
mahach666
force-pushed
the
feature/issue-28-pcd
branch
from
November 17, 2026 15:02
f171a28 to
c733b38
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Based on #76 (the branch
feature/issue-25-las-reader); merge the earlier pull requests first.What changed
PclFileKind.Pcd,PcdDocument/PcdScan): the 0.7 header (entries in the documented order,COUNT optional), ASCII, binary and binary compressed (LZF, decoded by a decoder of its own) point data, the
declared fields, organised (row after row) and unorganised clouds, and the viewpoint kept as metadata (not
applied). Positions come from x, y and z; colour from packed rgb/rgba; intensity; normals from
normal_x/normal_y/normal_z. Channel availability follows the file; points with non-finite coordinates are not
returned.
PointCountis WIDTH times HEIGHT, validated against POINTS at open.PclFile.OpenandDetectKindhandle.pcd: PCD has no signature, so a strict header structure(all entries in order) in any extension decides; an extension alone never suffices.
Files changed
src/PclIO/Formats/Pcd/PcdDocument.cs: new reader (header parser, three storage modes, SoA gather forcompressed data, chunked streaming reads).
src/PclIO/Internal/LzfDecoder.cs: new exact-size LZF decoder (literal runs, overlapping matches).src/PclIO/PclFileKind.cs,src/PclIO/PclFile.cs,src/PclIO/Internal/KindDetector.cs: thePcdkind,structure detection (256 KiB probe, position restored) and opening.
src/PclIO.Cli/Program.cs: the help text lists PCD as a detected input format.tests/PclIO.Tests/SyntheticFixtures.cs:PcdSamplePoint,CreateSyntheticPcd(fields, storage modes,organised grids, count overrides),
CreatePcdFilefor malformed headers, and a test-only greedyLzfCompress.tests/PclIO.Tests/LzfDecoderTests.cs: hand-built token vectors (independent of the test encoder) plusencoder round-trips and truncated/overrun/trailing rejections.
tests/PclIO.Tests/FormatTests.cs: PCD section (open metadata, all three storage round trips, organisedorder, NaN skipping, limit/step, Blocks/parallelism ignored, missing positions, unusable colour, unknown
data type, bad order, grid/count mismatch, ascii/binary/compressed truncation, corrupt LZF, size mismatch).
tests/PclIO.Tests/KindDetectionTests.cs,tests/PclIO.Tests/RealFileTests.cs: structure detection and theskipped-unless-present
.pcdinvariant test.README.md,docs/public-api.md,docs/getting-started.md,CHANGELOG.md: the new behaviour and limits.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 772 passed, 12 skipped (private-scan tests), 1 failed on .NET 8 and .NET 10. The singlefailure is
RepositoryHygieneTests.Git_History..., which flags the already-pushed issue API: Streaming and parallel decoding for very large files #24 commit0a78bc6for non-UTC dates — outside this PR; fixing it needs a force-push of
feature/issue-24-leica-parallel,which I did not do without instruction. Every test covering this PR passes.
Limits
NotSupportedException. Colour, intensityand normals of an uninterpretable shape stay unread (points without that channel) instead of failing.
field level); count-1 fields — the common case — are exact.
Blocks/MaxDegreeOfParallelismare ignored.