Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-28-pcd
branch
from
November 17, 2026 15:02
f171a28 to
c733b38
Compare
mahach666
force-pushed
the
feature/issue-29-ply
branch
from
November 17, 2026 15:02
c114f5f to
2162851
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Based on #77 (the branch
feature/issue-28-pcd); merge the earlier pull requests first.What changed
PclFileKind.Ply,PlyDocument/PlyScan): ASCII and binary little and big endian files witha vertex element. Positions come from x, y and z; 8-bit colour from red, green and blue (with alpha when
present); intensity; normals from nx, ny and nz — by those conventional names in any numeric type. Faces and
all other elements are ignored (fixed-size elements before the vertices are skipped). Vertices with
non-finite coordinates are not returned.
PointCountis the declared vertex count.PclFile.OpenandDetectKindhandle.ply: theplymagic word plus header structure (format line andend_header in order) in any extension; an extension alone never suffices.
Files changed
src/PclIO/Formats/Ply/PlyDocument.cs: new reader (strict header parser, three storage modes, chunkedstreaming reads, per-type value conversion with range checks).
src/PclIO/PclFileKind.cs,src/PclIO/PclFile.cs,src/PclIO/Internal/KindDetector.cs: thePlykind,magic-plus-structure detection (256 KiB probe, position restored) and opening.
src/PclIO.Cli/Program.cs: the help text lists PLY as a detected input format.tests/PclIO.Tests/SyntheticFixtures.cs:PlySamplePoint,CreateSyntheticPly(three storages, faces,custom properties) and
CreatePlyFilefor malformed headers.tests/PclIO.Tests/FormatTests.cs: PLY section (open metadata, all three storage round trips, ignoredfaces, NaN skipping, limit/step, Blocks/parallelism ignored, missing positions/vertices, unsupported
version, skipped/variable preceding elements, ascii/binary truncation, bad value count, unknown type,
wrong signature).
tests/PclIO.Tests/KindDetectionTests.cs,tests/PclIO.Tests/RealFileTests.cs: structure detection andthe skipped-unless-present
.plyinvariant test.README.md,docs/public-api.md,docs/getting-started.md,CHANGELOG.md: the new behaviour and limits.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 794 passed, 13 skipped (private-scan tests), 1 failed on .NET 8 and .NET 10. The singlefailure is
RepositoryHygieneTests.Git_History..., which flags the already-pushed issue API: Streaming and parallel decoding for very large files #24 commit0a78bc6for non-UTC dates — outside this PR; fixing it needs a force-push of
feature/issue-24-leica-parallel,which I did not do without instruction. Every test covering this PR passes (this commit itself uses UTC
dates and is not flagged).
Limits
NotSupportedException. Colour needs 8-bit red, green and blue; other shapes stay unread.rejected with
NotSupportedException.Blocks/MaxDegreeOfParallelismare ignored.