Repository navigation
Conversation
…veform bit and reject compressed LAZ
mahach666
force-pushed
the
feature/issue-24-leica-parallel
branch
from
November 17, 2026 15:02
0a78bc6 to
2183329
Compare
mahach666
force-pushed
the
feature/issue-25-las-reader
branch
from
November 17, 2026 15:02
d08536a to
479c49d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
Based on #75 (the branch
feature/issue-24-leica-parallel); merge the earlier pull requests first.What changed
PclFileKind.Las,LasDocument/LasScan): versions 1.0 to 1.4 with point formats 0 to 10,the legacy and the extended 1.4 point counts, scale and offset, and the coordinate system records when present.
Positions, intensity (0..1), classification and RGB for the colour formats (2, 3, 5, 7, 8, 10) are read; GPS time,
return numbers, scan angles, point source ids, near infrared and waveform packet descriptors are not interpreted,
and extra bytes past a format's base size are skipped. Extended VLRs are not read.
PclFile.OpenandDetectKindhandle.las: detection is by theLASFsignature with any extension except.laz, which shares the signature and stays unknown until the LAZ reader (issue Format: LAZ (*.laz) #26) exists. A.lasfile withthe wrong content is unknown, and opening it throws
NotSupportedException.HasColorsfor the colour formats,HasIntensitiesalways true,HasNormalsalways false.PointCountis the header count (the extended 1.4 count when it states one) and isnot checked against the point data until the points are read; a truncated read fails then.
Files changed
src/PclIO/Formats/Las/LasDocument.cs: new reader (header, bounded VLR walk, GeoTIFF/WKT coordinate system,chunked streaming point reads).
src/PclIO/PclFileKind.cs,src/PclIO/PclFile.cs,src/PclIO/Internal/KindDetector.cs: theLaskind,detection and opening.
src/PclIO.Cli/Program.cs: the help text lists LAS as a detected input format.tests/PclIO.Tests/SyntheticFixtures.cs:LasSamplePoint,CreateSyntheticLas(versions, formats 0-10,scale/offset, VLRs, extra bytes, count and record-length overrides) and EPSG/WKT VLR helpers.
tests/PclIO.Tests/FormatTests.cs: LAS section (open metadata, round trip, 1.4 extended counts/scale/offset/EPSG,all formats 0-10, limit/step, Blocks/parallelism ignored, exporter output reads back, WKT/unknown CRS,
wrong signature, unsupported version/format, truncated points, short record length, oversized/overrunning/too
many VLRs, skipped extra bytes).
tests/PclIO.Tests/KindDetectionTests.cs: signature detection, wrong-content and.lazcases.tests/PclIO.Tests/RealFileTests.cs: skipped-unless-present.lasinvariant test.README.md,docs/public-api.md,docs/getting-started.md,CHANGELOG.md: the new behaviour and limits.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 738 passed, 1 failed, 11 skipped (10 private-scan tests + environment-dependent) on .NET 8and .NET 10. The single failure is
RepositoryHygieneTests.Git_History_Holds_Only_The_Public_Identity_UTC_Dates_And_Clean_Messages,which flags commit
0a78bc6(the already-pushed issue API: Streaming and parallel decoding for very large files #24 commit) for non-UTC author/committer dates. Thatcommit is outside this PR; fixing its dates needs a force-push of
feature/issue-24-leica-parallel, which Idid not do without instruction. Every test covering this PR's changes passes.
Limits
NotSupportedExceptionat open; a LAS file never guesses.Blocks/MaxDegreeOfParallelismare ignored (no independent blocks).