Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-23-zstd-performance
branch
from
November 17, 2026 15:02
c03a024 to
a0245c9
Compare
mahach666
force-pushed
the
feature/issue-24-leica-parallel
branch
from
November 17, 2026 15:02
0a78bc6 to
2183329
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
Based on #74 (the branch
feature/issue-23-zstd-performance); merge the earlier pull requests first.What changed
BlockRange(StartBlock,BlockCount) andPclReadOptions.Blocksselect the blocks of a scan in file order; per scan, so a setup scan ranges over its own blocks. A range past the last block yields no points;BlockCount = 0yields none.PclReadOptions.MaxDegreeOfParallelism(default 1, sequential streaming). Above 1 the Leica reader decodes the selected blocks in parallel on thread-localFileStreams and yields points in file order with consecutiveIndexvalues.MaxPoints/SubsampleStepsemantics, warnings andStrictmatch the sequential read; a truncated read (MaxPointsstops early) reports nothing.LgsxScanrefactored to shared helpers: one chain walk, range slicing, per-block decode (DecodeBlock), shared unpack (UnpackBlock), ordered parallel combine withIndexrenumbering, andAggregateExceptionunwrapping (parallel failure surfaces as the originalInvalidDataException).blockCount) and single-damaged-block files (damagedBlock).Files changed
src/PclIO/BlockRange.cs: new range option type.src/PclIO/PclReadOptions.cs:BlocksandMaxDegreeOfParallelism(validated).src/PclIO/Formats/Leica/LgsxDocument.cs: refactor (shared chain/range/decode/unpack, ordered parallel combine,Indexhandling,MaxPointscaps, warning/Strictbehavior,AggregateExceptionunwrapping).tests/PclIO.Tests/SyntheticFixtures.cs:blockCount/damagedBlockfixture params.tests/PclIO.Tests/FormatTests.cs: range, past-end, parallel-order, parallel-range,MaxPointscap, damaged-block (both paths + range around it), truncated-file (both paths),MaxPointstruncation suppresses warnings,Stricton selected damaged block, non-Leica ignore test.tests/PclIO.Tests/OptionsAndPathTests.cs: defaults and validation for the new options.README.md,docs/public-api.md,docs/getting-started.md,CHANGELOG.md: Leica-only range/parallel behavior and limits.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 706 passed, 0 failed, 10 skipped (tests needing private scan files) on .NET 8 and .NET 10.Limits
Blocksand parallel decoding; the parallel read holds the decoded points of the selected blocks, while sequential decoding holds one block at a time.MaxPointsstops early; the cap only limits yielded points.PointCountstill counts all stored blocks, not the selected range.