Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-19-e57-validity
branch
from
November 17, 2026 15:02
6c003d6 to
1dbdf82
Compare
mahach666
force-pushed
the
feature/issue-20-e57-codecs
branch
from
November 17, 2026 15:02
b28942a to
a9c92b5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
Based on #70 (the branch
feature/issue-19-e57-validity); merge the earlier pull requests first.What changed
<codecs>vector names anything is now rejected with a message that names the codec elements(e.g.
the scan uses compressed vector codecs other than plain bit-packing (codec, mysteryCodec)), instead of a generictext. Plain bit-packing (an empty codecs vector) decodes as before.
a 16-bit value), so wider prototypes decode. A larger prototype still lists and fails with
NotSupportedExceptionwhenits points are read.
E57Specaccepts custom codecs XML for tests.Files changed
src/PclIO/Formats/E57/E57Document.cs: codec naming (DescribeCodecs), the raised limit and its message, updated classdocumentation.
tests/PclIO.Tests/E57Spec.cs: the newCodecsXmlproperty.tests/PclIO.Tests/FormatTests.cs: new tests for a named codec, for an over-limit prototype and for a 1503-fieldprototype that decodes.
tests/PclIO.Tests/InputHardeningTests.cs: the field-limit boundary test moved to 65535/65536.README.md,CHANGELOG.md: the new behaviour and limits.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 656 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
implementation-derived knowledge) no further E57 vector codec is attested, so there is nothing further to decode. A file
that names another codec keeps today's behaviour (listed, rejected by name at read time) instead of being guessed.
If test files using another standardized codec become available, only the layout builder needs a new branch.