Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-20-e57-codecs
branch
from
November 17, 2026 15:02
b28942a to
a9c92b5
Compare
mahach666
force-pushed
the
feature/issue-21-edgewise-scale
branch
from
November 17, 2026 15:02
c88b0e4 to
a5f96ab
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
Based on #71 (the branch
feature/issue-20-e57-codecs); merge the earlier pull requests first.What changed
PclReadOptions.EdgeWiseCoordinateScale(metres per unit, must be finite and above zero). The files do not declare thescale — the database carries only bounds and file references, and a point record is just three 16-bit offsets — so the
default keeps the long-standing assumption (32768 units = 0.128 m) and the caller states it when the files use another
scale. Default reads decode exactly as before.
EdgeWiseScan.ReadPointsuses the scale from its read options; the class documentation states the record layout.Files changed
src/PclIO/PclReadOptions.cs: the new validatedEdgeWiseCoordinateScaleoption.src/PclIO/Formats/EdgeWise/EdgeWiseDocument.cs: the scale comes from the read options; record layout documented.tests/PclIO.Tests/FormatTests.cs: a test that reads with a stated scale.tests/PclIO.Tests/OptionsAndPathTests.cs: the default value and the validation of the new option.README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 663 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
.c3dbdatabase holds bounds and file references, the.c3ptxrecords hold only centre + counts + int16 offsets), so the assumption stays the default rather than beingreplaced by a stored value.
is available; wider records fail the size check as before. Only positions are returned and no exporter writes normals.