Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-18-e57-spherical
branch
from
November 17, 2026 15:01
7350d6a to
ee38a26
Compare
mahach666
force-pushed
the
feature/issue-19-e57-validity
branch
from
November 17, 2026 15:02
6c003d6 to
1dbdf82
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19
Based on #69 (the branch
feature/issue-18-e57-spherical); merge the earlier pull requests first.What changed
cartesianInvalidState/sphericalInvalidState(matching the representation) drop the point,
isColorInvalid/isIntensityInvalidleave the point without thatchannel. A non-zero flag means invalid. Only one-byte flag streams are honoured; any other shape stays unread like an
unknown field, so files the reader cannot interpret keep today's behaviour instead of failing.
must share one encoding or colour is reported absent, as before.
(normalized by its maximum) is decoded. Malformed auxiliary fields leave the channel unread instead of failing the file.
HasColors/HasIntensitiesreport the new encodings. Images are still not read.Files changed
src/PclIO/Formats/E57/E57Document.cs: layout for validity streams, wider colour and intensity encodings, skipping andchannel clearing in
ReadPoints, record-size agreement for the new widths, updated documentation.tests/PclIO.Tests/FormatTests.cs: new tests for skipped points and cleared channels, spherical validity, 16-bit colour,float and scaled intensity, mixed colour encodings, uninterpretted validity shapes and a partial colour record.
README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 653 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
the byte model of the rest of the E57 code: validity streams must hold one flag byte per record to be honoured, colour
stays Integer-from-zero, and scaled colour / float colour stay unsupported. Files outside that keep working as before.