Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-17-e57-scaled-integers
branch
from
November 17, 2026 15:01
fe2057c to
b9c5f90
Compare
mahach666
force-pushed
the
feature/issue-18-e57-spherical
branch
from
November 17, 2026 15:01
7350d6a to
ee38a26
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
Based on #68 (the branch
feature/issue-17-e57-scaled-integers); merge the earlier pull requests first.What changed
sphericalRange,sphericalAzimuth,sphericalElevation) are now decoded:each triple is converted to a Cartesian point as the standard defines (range in the file's unit, azimuth and elevation in
radians). Float and scaled-integer components both work, per component.
with
NotSupportedExceptionwhen its points are read, with a message that names the problem.Files changed
src/PclIO/Formats/E57/E57Document.cs: spherical layout (streams, sizes, scaled-integer parameters), conversion inReadPoints, record-count agreement for spherical streams, updated class documentation.tests/PclIO.Tests/FormatTests.cs: new tests for float spherical decoding with the pose applied, for scaled-integerspherical components, for a partial triple, for a both-kinds prototype and for a partial spherical record.
README.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 645 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
decides. A file with two complete representations is rejected.
Boundsstill comes fromcartesianBoundswhen the file states it.