Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-16-snappy-window
branch
from
November 17, 2026 15:01
02cc715 to
535d93f
Compare
mahach666
force-pushed
the
feature/issue-17-e57-scaled-integers
branch
from
November 17, 2026 15:01
fe2057c to
b9c5f90
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Based on #67 (the branch
feature/issue-16-snappy-window); merge the earlier pull requests first.What changed
ScaledIntegerCartesian coordinates are now decoded: the raw integer times the scale plus the offset.The binary width (1, 2, 4 or 8 bytes) follows from the
minimum/maximumrange of the field — unsigned when the minimumis not negative, signed otherwise.
scaledefaults to 1 andoffsetto 0 when absent.or offset) fails with
InvalidDataExceptionwhen the file is opened. Other types for Cartesian fields are still reportedas unsupported when the points are read.
Files changed
src/PclIO/Formats/E57/E57Document.cs: per-axis scaled-integer layout (width, signedness, scale, offset), decoding inReadPoints, updated class documentation.src/PclIO/Internal/Bytes.cs: the newReadInt64LEhelper.tests/PclIO.Tests/FormatTests.cs: the old not-decoded test replaced with decoding tests (mixed scaled/float axes withscale and offset, 1/4/8-byte widths with defaults, empty range, non-finite scale, partial record).
README.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 640 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
IntegerCartesian fields stay unsupported; onlyScaledIntegerwas asked for.that packs its integers in another width fails on the record-size check.
doublepositions, as with every coordinate the library holds.