Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-15-pinpoint-dataobject-count
branch
from
November 17, 2026 15:01
19c19c6 to
d4cd705
Compare
mahach666
force-pushed
the
feature/issue-16-snappy-window
branch
from
November 17, 2026 15:01
02cc715 to
535d93f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Based on #66 (the branch
feature/issue-15-pinpoint-dataobject-count); merge the earlier pull requests first.What changed
to a power of two, capped at 8 MiB per stream, so memory use stays bounded while streams with copies up to 8 MiB back
decode. A stream whose copies reach back further than its window is still reported as unsupported instead of being
decoded wrongly, with a message that names the window and the cap.
Files changed
src/PclIO/Internal/SnappyReader.cs: adaptive window sized in the constructor; the window size is stored separatelyfrom the rented buffer (the pool may hand back a larger array); the preamble is parsed before anything is rented so its
failure only disposes the source.
tests/PclIO.Tests/SnappyReaderTests.cs: the unsupported-offset test now uses an offset beyond the new cap; new tests fora 2 MiB-back copy and for correctness when the capped window wraps.
tests/PclIO.Tests/PinPointPackedTests.cs: new end-to-end test with a points channel that copies 2 MiB back.README.md,CHANGELOG.md: the new bound (8 MiB) and the per-stream window cap.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 636 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
NotSupportedExceptionwhen its points are read,without an earlier warning at open time: detecting it would need a full pass over the compressed elements, which the
open path deliberately avoids. This is now documented.