Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-14-pinpoint-plausibility
branch
from
November 17, 2026 15:01
03f4c22 to
4ca1bc1
Compare
mahach666
force-pushed
the
feature/issue-15-pinpoint-dataobject-count
branch
from
November 17, 2026 15:01
19c19c6 to
d4cd705
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Based on #65 (the branch
feature/issue-14-pinpoint-plausibility); merge the earlier pull requests first.What changed
refers to (
table.PointCount, as for manifests with a scan position list), instead of always reporting 0. Missing ordamaged data files still report 0, with the same warnings as before.
Files changed
src/PclIO/Formats/PinPoint/PinPointDocument.cs: the count comes from the channel table; the outdated comment updated.tests/PclIO.Tests/FormatTests.cs: new tests for the count from the file, for shared files, for a missing file and for adamaged file.
README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 634 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
TotalPointCountcan exceed the number of uniquestored points. The manifest does not record the shares, so nothing better can be reported; this is now documented.