Skip to content

Take the point count of a PinPoint data object from its data file - #66

Open
mahach666 wants to merge 1 commit into
feature/issue-14-pinpoint-plausibilityfrom
feature/issue-15-pinpoint-dataobject-count
Open

mahach666 wants to merge 1 commit into
feature/issue-14-pinpoint-plausibilityfrom
feature/issue-15-pinpoint-dataobject-count

Conversation

@mahach666

Copy link
Copy Markdown
Contributor

Closes #15

Based on #65 (the branch feature/issue-14-pinpoint-plausibility); merge the earlier pull requests first.

What changed

  • A PinPoint location of a manifest with a data object list now takes its point count from the data file the object
    refers to
    (table.PointCount, as for manifests with a scan position list), instead of always reporting 0. Missing or
    damaged data files still report 0, with the same warnings as before.
  • Locations that share one data file each report its full count, because the shares are not recorded in the manifest.

Files changed

  • src/PclIO/Formats/PinPoint/PinPointDocument.cs: the count comes from the channel table; the outdated comment updated.
  • tests/PclIO.Tests/FormatTests.cs: new tests for the count from the file, for shared files, for a missing file and for a
    damaged file.
  • README.md, docs/public-api.md, CHANGELOG.md: the new behaviour.

Tests

  • dotnet build — 0 warnings, 0 errors.
  • dotnet test — 634 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.

Limits

  • Locations that share one data file each report the full file count, so TotalPointCount can exceed the number of unique
    stored points. The manifest does not record the shares, so nothing better can be reported; this is now documented.

@mahach666
mahach666 force-pushed the feature/issue-14-pinpoint-plausibility branch from 03f4c22 to 4ca1bc1 Compare November 17, 2026 15:01
@mahach666
mahach666 force-pushed the feature/issue-15-pinpoint-dataobject-count branch from 19c19c6 to d4cd705 Compare November 17, 2026 15:01

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant