Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-13-pinpoint-normals
branch
from
November 17, 2026 15:01
0f35ff9 to
ef58f14
Compare
mahach666
force-pushed
the
feature/issue-14-pinpoint-plausibility
branch
from
November 17, 2026 15:01
03f4c22 to
4ca1bc1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14
Based on #64 (the branch
feature/issue-13-pinpoint-normals); merge the earlier pull requests first.What changed
PclReadOptions.MaxCoordinateMagnitude(default 5000, in the file's ownunit; null switches the magnitude limit off). Non-finite (NaN or infinite) coordinates are still never returned. Other
readers ignore the option.
The coordinate plausibility rule dropped N points (M with non-finite coordinates, K beyond the magnitude limit of ...).), instead of dropping themsilently. With
PclReadOptions.Strictthe read fails withInvalidDataExceptioninstead, per the documented contractof
Strict.Files changed
src/PclIO/PclReadOptions.cs: the newMaxCoordinateMagnitudeoption (validated, negative rejected).src/PclIO/Formats/PinPoint/PinPointDocument.cs: the rule uses the option, counts non-finite and out-of-range dropsseparately and reports them;
PinPointScanholds the document for warnings; reader documentation updated.tests/PclIO.Tests/FormatTests.cs: new tests for a raised limit, a switched-off limit, the warning count and strict mode.tests/PclIO.Tests/OptionsAndPathTests.cs: the default value and the validation of the new option.README.md,docs/getting-started.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 630 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
MaxPointscounts only what it visited, and thewarning is added only when the whole point data was read. Repeated identical reads do not repeat the warning.