Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-12-pinpoint-filterbits
branch
from
November 17, 2026 15:01
afcc67f to
993e93c
Compare
mahach666
force-pushed
the
feature/issue-13-pinpoint-normals
branch
from
November 17, 2026 15:01
0f35ff9 to
ef58f14
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
Based on #63 (the branch
feature/issue-12-pinpoint-filterbits); merge the earlier pull requests first.What changed
Normalschannel of the PinPoint sectioned layout is now read and validated (three float32 components per storedpoint, checked against the stored point count like the other channels). A wrong size fails with
InvalidDataException.HasNormalsreports what the file contains for the sectioned layout too (it already did for the table layout): the packedform checks the presence of the channel instead of dividing a compressed length.
Files changed
src/PclIO/Formats/PinPoint/PinPointPackedLayout.cs:Normalsis a known channel (12 bytes per point).src/PclIO/Formats/PinPoint/PinPointDocument.cs: packed-awareHasNormalsand point total, normals stream in thetrailing-bytes check, reader documentation updated.
tests/PclIO.Tests/PinPointPackedFixtures.cs: the fixture accepts normals (float[], three components per point).tests/PclIO.Tests/PinPointPackedTests.cs: new tests for normals being read (values, all-zero means none) and for awrong-size channel; existing no-channel tests now also assert
HasNormals == false.README.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 624 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
Normalswith three float32 components per point, the same shape as thetable layout. A file that stores them under another name or in another encoding stays unread for that channel; the reader
does not guess.
RowColIndexstays unread.