Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-11-recap-project-transform
branch
from
November 17, 2026 15:01
26d664f to
0821a5b
Compare
mahach666
force-pushed
the
feature/issue-12-pinpoint-filterbits
branch
from
November 17, 2026 15:01
afcc67f to
993e93c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Based on #62 (the branch
feature/issue-11-recap-project-transform); merge the earlier pull requests first.What changed
FilterBitschannel of the PinPoint sectioned layout is now read and validated (one flag byte per stored point,checked against the stored point count like the other channels). A wrong size fails with
InvalidDataException.PclReadOptions.ExcludeFilteredPoints(default false) excludes the points with a non-zero flag from the read;the rest keeps consecutive
Indexvalues. By default every stored point is returned, as before.PinPointScan.HasFilterBitsreports whether the data file holds the flags channel.Files changed
src/PclIO/PclReadOptions.cs: the newExcludeFilteredPointsoption.src/PclIO/Formats/PinPoint/PinPointPackedLayout.cs:FilterBitsis a known channel (1 byte per point).src/PclIO/Formats/PinPoint/PinPointDocument.cs: the flags stream is opened, validated and applied;HasFilterBitsis new;the reader documentation updated.
tests/PclIO.Tests/PinPointPackedFixtures.cs: the fixture accepts flag bytes (filterBits).tests/PclIO.Tests/PinPointPackedTests.cs: new tests for the default behaviour, the opt-in exclusion and a wrong-size channel.README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 622 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
clean-room rule), so any non-zero value counts as filtered. This is stated in the API documentation.
PointCountstill counts all stored points; excluded points are dropped while reading, like the plausibility rule.RowColIndexstays unread.