Repository navigation
Conversation
…-only node keep the scan placement
mahach666
force-pushed
the
feature/issue-10-recap-channels
branch
from
November 17, 2026 15:01
ae5bbeb to
7d8cda8
Compare
mahach666
force-pushed
the
feature/issue-11-recap-project-transform
branch
from
November 17, 2026 15:01
26d664f to
0821a5b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Based on #61 (the branch
feature/issue-10-recap-channels); merge the earlier pull requests first.What changed
ApplyTransformis false.When the manifest states no transform for a node, the transform of the referenced
.rcsfile is used instead, so only oneof the two transforms is ever applied.
ParseNodeTransformnow also reports whether the manifest states a transform for the node at all;RcpScankeeps that flagand uses it when reading points.
Files changed
src/PclIO/Formats/Recap/RcpProjectDocument.cs: the project transform is applied to points (withApplyTransform: falsepassed to the scan-file reader so the two transforms do not stack); the class documentation updated.
tests/PclIO.Tests/SyntheticFixtures.cs: the synthetic project manifest can omit the transform (withTransform: false).tests/PclIO.Tests/FormatTests.cs: new tests for the applied project transform, for the fallback to the scan-file transformand for a damaged transform.
README.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 620 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
PclTransformappliesscale and translation (or a 4x4 matrix) only.
InvalidDataException.