Skip to content

Apply the node transform of a ReCap project to its points - #62

Open
mahach666 wants to merge 2 commits into
feature/issue-10-recap-channelsfrom
feature/issue-11-recap-project-transform
Open

mahach666 wants to merge 2 commits into
feature/issue-10-recap-channelsfrom
feature/issue-11-recap-project-transform

Conversation

@mahach666

Copy link
Copy Markdown
Contributor

Closes #11

Based on #61 (the branch feature/issue-10-recap-channels); merge the earlier pull requests first.

What changed

  • The transform of a ReCap project scan node is now applied to the points of the scan unless ApplyTransform is false.
    When the manifest states no transform for a node, the transform of the referenced .rcs file is used instead, so only one
    of the two transforms is ever applied.
  • ParseNodeTransform now also reports whether the manifest states a transform for the node at all; RcpScan keeps that flag
    and uses it when reading points.

Files changed

  • src/PclIO/Formats/Recap/RcpProjectDocument.cs: the project transform is applied to points (with ApplyTransform: false
    passed to the scan-file reader so the two transforms do not stack); the class documentation updated.
  • tests/PclIO.Tests/SyntheticFixtures.cs: the synthetic project manifest can omit the transform (withTransform: false).
  • tests/PclIO.Tests/FormatTests.cs: new tests for the applied project transform, for the fallback to the scan-file transform
    and for a damaged transform.
  • README.md, CHANGELOG.md: the new behaviour.

Tests

  • dotnet build — 0 warnings, 0 errors.
  • dotnet test — 620 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.

Limits

  • The rotation values of the project transform are stored for information but not applied, as before: PclTransform applies
    scale and translation (or a 4x4 matrix) only.
  • A damaged transform value in the manifest is rejected at open time with InvalidDataException.

@mahach666
mahach666 force-pushed the feature/issue-10-recap-channels branch from ae5bbeb to 7d8cda8 Compare November 17, 2026 15:01
@mahach666
mahach666 force-pushed the feature/issue-11-recap-project-transform branch from 26d664f to 0821a5b Compare November 17, 2026 15:01

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant