Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-9-recap-node-layouts
branch
from
November 17, 2026 15:01
91f8120 to
7fc2c2b
Compare
mahach666
force-pushed
the
feature/issue-10-recap-channels
branch
from
November 17, 2026 15:01
ae5bbeb to
7d8cda8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
Based on #60 (the branch
feature/issue-9-recap-node-layouts); merge the earlier pull requests first.What changed
HasColors,HasIntensitiesandHasNormalsof a ReCap scan are no longer constants: they are read from the nodetable. The size of the payload of a node tells which channels its points hold — a record that holds the intensity and the
colour is longer than one with the position only, and a node that holds more bytes per point also holds the plane of the
normals.
node does not hold.
RcsScanDocument.HasColorData,HasNormalDataandHasIntensityDatareport the same as the scan.Files changed
src/PclIO/Formats/Recap/RcsScanDocument.cs: the channels are detected from the node table, the points are read with thechannels of their node, and the node payload check accepts the shorter record.
tests/PclIO.Tests/SyntheticFixtures.cs: the synthetic scan can hold records without colour and intensity.tests/PclIO.Tests/FormatTests.cs: new tests for a scan without colour, with colour and normals and without normals.README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 617 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
record size is rejected with
NotSupportedException..rcsfile was found, because the file is not openedwhen the project is read.