Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-8-faro-folder-layout
branch
from
November 17, 2026 15:01
d7a2b38 to
85e0f53
Compare
mahach666
force-pushed
the
feature/issue-9-recap-node-layouts
branch
from
November 17, 2026 15:01
91f8120 to
7fc2c2b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
Based on #59 (the branch
feature/issue-8-faro-folder-layout); merge the earlier pull requests first.What changed
RcsLayoutin the code), sothat a further version is one small, reviewable addition instead of a change in the middle of the reader. The layout of major
version 3 is the one that is described.
versions. The file is still listed with its header, so that the metadata of the project stays visible.
RcsScanDocument.DecodedNodeLayoutVersionsnames the versions that are decoded, so that a caller can tell from the API whatthe reader supports.
Files changed
src/PclIO/Formats/Recap/RcsScanDocument.cs: the newRcsLayouttype, the version lookup and the rejection message.tests/PclIO.Tests/FormatTests.cs: new tests for the rejection message, for the decoded versions and for a truncated node table.README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 614 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
used for the tests, so that its offsets can be verified; the repository has no such file, so only the layout of major version 3
is described. Everything else — the header, the metadata, the scan list of a project — is read as before.
unknown version stays readable.