Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-7-faro-point-count
branch
from
November 17, 2026 15:01
ba421d1 to
3b6b1b9
Compare
mahach666
force-pushed
the
feature/issue-8-faro-folder-layout
branch
from
November 17, 2026 15:01
d7a2b38 to
85e0f53
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
Based on #58 (the branch
feature/issue-7-faro-point-count); merge the earlier pull requests first.What changed
grid, so its size must be a multiple of the size of the grid, and the number of bytes per sample follows from it. The
result is available as
FaroScan.RecordSizeand in the metadata of the document.intensities of the scanner (scaled by 2048, as before), wider values are 16-bit intensities (scaled by 65535).
document says which layout was derived.
Files changed
src/PclIO/Formats/Faro/FaroFlsDocument.cs: the layout is derived when the folder is opened, the scale of the intensity isread from the data, and
RecordSizeis a new property.tests/PclIO.Tests/SyntheticFixtures.cs: the synthetic folder scan can hold samples of another size, other intensity values,extra bytes or fewer samples than the grid.
tests/PclIO.Tests/FormatTests.cs: new tests for the derived layout, for the 16-bit intensity, for sizes that do not fit andfor a truncated stream.
README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 611 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
intensity the second one. A format that stores them in another order is not detected.
read with the 12-bit scale even when the format stores 16-bit values.