Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-6-leica-incomplete-data
branch
from
November 17, 2026 15:01
cf0c5ae to
1fdf732
Compare
mahach666
force-pushed
the
feature/issue-7-faro-point-count
branch
from
November 17, 2026 15:01
ba421d1 to
3b6b1b9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
Based on #57 (the branch
feature/issue-6-leica-incomplete-data); merge the earlier pull requests first.What changed
PclScan.PointCountof a FARO scan is now the number of valid returns, which is what a full read returns. The count ismade on the first access, which reads the distance data of the scan, and is cached afterwards.
FaroScan.GridSize, so that the difference between the grid and thevalid returns stays visible.
in one place and is used by the counter and by the reader, so the two cannot disagree.
Files changed
src/PclIO/Formats/Faro/FaroFlsDocument.cs: the valid returns are counted,PointCountreports them,GridSizeis new and therule for a usable distance is shared.
tests/PclIO.Tests/SyntheticFixtures.cs: the synthetic scan can hold cells without a return (invalidCells).tests/PclIO.Tests/FormatTests.cs: new tests for a container and for a folder scan with cells without a return.README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 607 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
fails then with
InvalidDataException.