Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-5-leica-point-count
branch
from
November 17, 2026 15:01
285ad7e to
ddb5617
Compare
mahach666
force-pushed
the
feature/issue-6-leica-incomplete-data
branch
from
November 17, 2026 15:01
cf0c5ae to
1fdf732
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Based on #56 (the branch
feature/issue-5-leica-point-count); merge the earlier pull requests first.What changed
PclDocument.Warnings:PclReadOptions.Strictmakes such a read fail withInvalidDataExceptioninstead of adding the warning. The option isgeneral; a reader that cannot detect incomplete data ignores it.
Files changed
src/PclIO/PclReadOptions.cs: the newStrictoption.src/PclIO/Formats/Leica/LgsxDocument.cs: the counters, the report at the end of a read and the warning helper of the document.tests/PclIO.Tests/SyntheticFixtures.cs: the synthetic container can drop points, write an oversized frame and write a block the reader does not know.tests/PclIO.Tests/FormatTests.cs: new tests for the three cases, for the strict mode and for complete data.README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 605 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits
MaxPointssays nothing, because the counts woulddescribe only a part of the data.
shorter than a block header is treated as the end of the data.