Repository navigation
Conversation
mahach666
force-pushed
the
feature/issue-4-leica-poses-bounds
branch
from
November 17, 2026 15:01
fac5563 to
c753073
Compare
mahach666
force-pushed
the
feature/issue-5-leica-point-count
branch
from
November 17, 2026 15:01
285ad7e to
ddb5617
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Based on #55 (the branch
feature/issue-4-leica-poses-bounds); merge the earlier pull requests first.What changed
PclScan.PointCountof a Leica scan is now the number the container states: the header of the point data holds the number of points of the whole payload, and the record of a setup holds the number of points of that setup. Reading the count therefore no longer decodes the point data, which was the slow part (about 35 s for a container of 750 MB).Files changed
src/PclIO/Formats/Leica/LgsxDocument.cs: the count is read from the header of the point data and from the record of a setup, andLgsxScan.PointCountuses it when it is there.tests/PclIO.Tests/SyntheticFixtures.cs: the synthetic container writes the number of points into the header of the point data and into the record of a setup;withPointCount: falseleaves it out.tests/PclIO.Tests/FormatTests.cs: new tests for the stored count, for the agreement of the stored and the decoded count and for a count that does not decode the points.tests/PclIO.Tests/CliTests.cs: the test of a count that fails on its first access now uses a container that states no count.README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 600 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits