Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
What changed
.lgsx/.lgs) that assigns its points to its setups now opens as one scan per setup. The scan carries the id and the name of its setup (LgsxScan.Id/LgsxScan.Name), andLgsxDocument.Setupslists the setups of the container with the range each one declares.unified-cloudand the warning that the points are not assigned to the setups.Files changed
src/PclIO/Formats/Leica/LgsxDocument.cs: setup entries are collected with their range, the point blocks are assigned to them,LgsxSetupis a new public type,LgsxScanreads only the blocks that belong to it.tests/PclIO.Tests/SyntheticFixtures.cs: the synthetic container can give every setup its own point block and declare its range (assignPointsToSetups,overlappingSetupRanges).tests/PclIO.Tests/FormatTests.cs: new tests for one scan per setup, a setup without points and two setups that claim the same points.README.md,docs/public-api.md,CHANGELOG.md: the new behaviour.Tests
dotnet build— 0 warnings, 0 errors.dotnet test— 595 passed, 0 failed, 10 skipped (the tests that need private scan files) on .NET 8 and .NET 10.Limits