fix(web-ui): stabilize turn list navigation#1294
Open
snvtac wants to merge 1 commit into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VirtualMessageList.pinTurnToTopis temporarily unavailable, then retry when virtual items change.Fixes #1281
Type and Areas
Type:
bug fix / regression fix / UI/UX / test
Areas:
web UI, Flow Chat
Motivation / Impact
Long Flow Chat sessions could close the header turn list after clicking a turn even when the virtual list had not accepted the navigation request yet. Users saw the menu disappear while the chat stayed in place.
This change keeps the menu open for unaccepted non-current turn selections, retries the container-level turn pin when the virtualized items update, and only lets the header advance once the virtual list accepts the request.
Verification
pnpm --dir src/web-ui run test:run src/flow_chat/components/modern/FlowChatHeader.test.tsx src/flow_chat/components/modern/ModernFlowChatContainer.history-state.test.tsxpnpm run type-check:webgit diff --checkReviewer Notes
The fix is scoped to header turn-list navigation. It does not add side-panel history navigation or change
VirtualMessageListpin semantics.AI-assisted: yes. Testing level: focused automated regression tests plus Web UI type-check.
Checklist