fix(web-ui): stabilize turn list jumps#1291
Closed
snvtac wants to merge 1 commit into
Closed
Conversation
Author
|
Superseded by #1294, which keeps the same issue scope but includes regression coverage and full Web UI type-check validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize Flow Chat turn-list navigation when the virtual message list is not ready to accept a requested turn jump immediately.
Fixes #1281
Type and Areas
Type:
bug fix / UI/UX
Areas:
web UI / Flow Chat
Motivation / Impact
Clicking a non-current item in the Flow Chat header turn list could close the list even when
VirtualMessageList.pinTurnToTopreturnedfalse, leaving the chat view at the old position with no visible recovery.This change keeps non-current turn-list selections open until the jump is accepted by the virtual list, then lets the existing
currentTurneffect close the list after header navigation state advances. Failed jumps are retained as a bounded deferred request and retried on animation frames / virtual-item changes. Selecting the already-current turn still closes the list immediately.Verification
git diff --check --no-index src/web-ui/src/flow_chat/components/modern/__remote__/FlowChatHeader.main.tsx src/web-ui/src/flow_chat/components/modern/FlowChatHeader.tsx— passed, no outputgit diff --check --no-index src/web-ui/src/flow_chat/components/modern/__remote__/ModernFlowChatContainer.main.tsx src/web-ui/src/flow_chat/components/modern/ModernFlowChatContainer.tsx— passed, no outputpnpm dlx esbuild src/web-ui/src/flow_chat/components/modern/FlowChatHeader.tsx --loader:.tsx=tsx --format=esm --outfile=/tmp/bitfun-flowchat-header-check.js— passedpnpm dlx esbuild src/web-ui/src/flow_chat/components/modern/ModernFlowChatContainer.tsx --loader:.tsx=tsx --format=esm --outfile=/tmp/bitfun-modern-flowchat-container-check.js— passedNot run:
pnpm run type-check:webReason: full repository clone and tarball download stalled in this environment, so only the relevant source files were fetched through the GitHub API for a focused patch.
Reviewer Notes
main, as requested byCONTRIBUTING.md.TurnHistoryPanel.tsxfollow-up mentioned in the issue is not included.Checklist