Skip to content

Comments

Fix ESLint errors in test files and source code#436

Closed
Copilot wants to merge 2 commits intocreate-new-ecs-systemfrom
copilot/sub-pr-432
Closed

Fix ESLint errors in test files and source code#436
Copilot wants to merge 2 commits intocreate-new-ecs-systemfrom
copilot/sub-pr-432

Conversation

Copy link
Contributor

Copilot AI commented Jan 11, 2026

Resolved 18 ESLint errors across test and source files identified by the linter.

Changes

  • audio-system.test.ts: Replaced any types with MockHowl interface for type-safe mock objects

    interface MockHowl {
      play: () => void;
    }
    
    const audioComponent: AudioEcsComponent = {
      sound: { play: mockPlay } as MockHowl,  // was: as any
      playSound: true,
    };
  • transform-system.ts: Extracted setTransformsToLocal and applyParentTransforms helper functions to reduce cognitive complexity from 29 to under threshold (15)

  • particle-emitter-system.test.ts: Added assertion to verify no particles created when emitter is empty

  • render-system.ts: Removed commented-out scissor test code

  • game.ts: Reordered class members to comply with member-ordering rules (public fields before private)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com>
Copilot AI changed the title [WIP] Create new ECS system architecture Fix ESLint errors in test files and source code Jan 11, 2026
Copilot AI requested a review from stormmuller January 11, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants