Create new ecs system by stormmuller · Pull Request #432 · Forge-Game-Engine/Forge

stormmuller · 2026-01-10T22:22:50Z

No description provided.

#427) * Initial plan * feat: migrate animation components and systems to new ECS style Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com>

* Initial plan * test: add comprehensive tests for audio system Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com>

… all component and systems

* Initial plan * fix: update ecs test imports and API usage Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: skip tests requiring old ECS API rewrite Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: resolve build errors from old ECS API usage Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: apply linting fixes Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: rewrite system tests for new ECS API Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: address code review feedback - use proper types, remove comments, delete empty test Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com>

* Initial plan * feat: update utility functions to use new ECS implementation Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: replace any types with proper type imports in add-camera Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * refactor: simplify add-camera by using Partial<CameraEcsComponent> Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: remove automatic system addition from addCamera to prevent duplicates Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: implement Stoppable interface and remove unnecessary return from addCamera Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * refactor: follow codebase conventions and uncomment migrated ECS code - Remove unnecessary note from addCamera documentation - Uncomment and migrate rotation, scale, flip, and animation code in create-sprite - Refactor Game constructor to follow codebase convention (private fields with getters) Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: remove time and world getters from Game class Remove the public getters for time and world as they were not requested. Update internal usage to reference private fields directly. Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> Co-authored-by: Storm <stormmuller2@gmail.com>

Copilot

Pull request overview

This PR introduces a complete rewrite of the ECS (Entity-Component-System) architecture, replacing class-based components and systems with a more data-oriented, performance-focused approach using sparse sets and symbol-based component identification.

Changes:

Replaces the entire ECS architecture with a new implementation using sparse sets for component storage
Migrates all components from classes to interfaces with symbol-based IDs
Converts all systems from classes to factory functions returning system objects
Removes the old Entity, World, and Game classes and associated infrastructure
Updates rendering, physics, particles, lifecycle, timer, and input systems to use the new ECS

Reviewed changes

Copilot reviewed 115 out of 115 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/new-ecs/*`	New ECS implementation with world, system, and component types
`src/utilities/sparse-set.ts`	High-performance sparse set data structure for component storage
`src/utilities/game.ts`	Simplified game loop manager
`src/common/components/*`	Component migrations to interface-based approach
`src/rendering/systems/*`	Rendering system migrations to new ECS
`src/physics/systems/*`	Physics system migrations
`src/particles/systems/*`	Particle system migrations
`src/lifecycle/systems/*`	Lifecycle system migrations
`src/timer/systems/*`	Timer system migration
`src/input/systems/*`	Input system migrations
`src/ecs/*`	Removal of old ECS implementation
`src/pooling/*`	Removal of object pooling infrastructure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-10T22:24:40Z

src/particles/systems/particle-emitter-system.test.ts

+    world = new EcsWorld();
    time = new Time();
+    random = new Random(12345);
+    world.addSystem(createParticleEmitterEcsSystem(time, random));


Callee is not a function: it has type undefined.

Copilot · 2026-01-10T22:24:40Z

src/particles/systems/particle-emitter-system.test.ts

+// Helper function to count entities in world
+function countEntities(world: EcsWorld): number {
+  let count = 0;
+  const testSystem = {


Unused variable testSystem.

… runtime checks (#433) * Initial plan * fix: update physics and particle emitter test files to meet requirements Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: revert unintended linting changes to non-test files Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: replace Vector2(0,0) with Vector2.zero and remove unnecessary try-catch blocks Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * fix: replace Vector2(0,0) with Vector2.zero and remove unnecessary comments Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com>

stormmuller · 2026-01-11T12:41:57Z

@copilot update the demo to use the new ECS system

Copilot · 2026-01-11T12:42:04Z

@stormmuller I've opened a new pull request, #435, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * feat(demo): update demo to use new ECS system Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * feat(demo): add camera system to demo Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> * refactor: replace ControlAdventurerEcsComponent with tag in control-adventurer system --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stormmuller <17644200+stormmuller@users.noreply.github.com> Co-authored-by: Storm <stormmuller2@gmail.com>

…s and utilities

stormmuller · 2026-01-11T18:09:11Z

@copilot fix the linting issues

Copilot · 2026-01-11T18:09:18Z

@stormmuller I've opened a new pull request, #436, to work on those changes. Once the pull request is ready, I'll request review from you.

…d improve assertions

stormmuller · 2026-01-11T18:54:03Z

@copilot please fix the build issues

Copilot · 2026-01-11T18:54:10Z

@stormmuller I've opened a new pull request, #437, to work on those changes. Once the pull request is ready, I'll request review from you.

…ery handling

… world management

stormmuller and others added 8 commits January 6, 2026 15:36

feat: started adding new ECS system

77186f6

refactor: streamline animation component and system implementations

0debc0b

feat: refactor audio component and system to ECS architecture

6b26982

feat: added new ecs implementation and removed the old one, migrating…

9b0af14

… all component and systems

Copilot AI review requested due to automatic review settings January 10, 2026 22:22

Copilot started reviewing on behalf of stormmuller January 10, 2026 22:23 View session

Copilot AI reviewed Jan 10, 2026

View reviewed changes

Copilot AI and others added 2 commits January 11, 2026 14:36

Merge branch 'dev' into create-new-ecs-system

4eb50fd

Copilot AI mentioned this pull request Jan 11, 2026

feat(demo): migrate demo to new ECS implementation #435

Merged

Copilot AI and others added 3 commits January 11, 2026 15:09

refactor: remove createBatch function from demo

69b6595

refactor: reorder imports and improve formatting in various test file…

04917a6

…s and utilities

Copilot AI mentioned this pull request Jan 11, 2026

Fix ESLint errors in test files and source code #436

Closed

refactor: update audio system tests to use Howl for sound playback an…

5e0c939

…d improve assertions

Copilot AI mentioned this pull request Jan 11, 2026

Fix build failures and package exports #437

Closed

stormmuller added 4 commits January 11, 2026 18:57

fix: update ECS module paths to new directory structure

4b97d17

refactor: remove pooling module from package exports

6e51749

docs: updated space shooter demo to use new ECS

e2653be

refactor: update ECS system interfaces to include tags and improve qu…

d3b4dbf

…ery handling

stormmuller added 2 commits January 17, 2026 14:45

fix: correct bullet and player movement direction in ECS systems

f23f00f

docs: update ECS documentation for components, entities, systems, and…

4ed8139

… world management

stormmuller merged commit 9f1154a into dev Jan 17, 2026
10 checks passed

stormmuller deleted the create-new-ecs-system branch January 17, 2026 16:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Create new ecs system#432

Create new ecs system#432
stormmuller merged 20 commits intodevfrom
create-new-ecs-system

stormmuller commented Jan 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

stormmuller commented Jan 11, 2026

Uh oh!

Copilot AI commented Jan 11, 2026

Uh oh!

stormmuller commented Jan 11, 2026

Uh oh!

Copilot AI commented Jan 11, 2026

Uh oh!

stormmuller commented Jan 11, 2026

Uh oh!

Copilot AI commented Jan 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

stormmuller commented Jan 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

stormmuller commented Jan 11, 2026

Uh oh!

Copilot AI commented Jan 11, 2026

Uh oh!

stormmuller commented Jan 11, 2026

Uh oh!

Copilot AI commented Jan 11, 2026

Uh oh!

stormmuller commented Jan 11, 2026

Uh oh!

Copilot AI commented Jan 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants