Repository navigation
refactor(cr): replace the Flux change request store with RTK Query - #8923
Draft
talissoncosta wants to merge 4 commits into
Draft
talissoncosta wants to merge 4 commits into
talissoncosta wants to merge 4 commits into
Conversation
…K Query behind change_requests_rtk The change request page reads one data hook. With change_requests_rtk on, it loads the change request and its feature through RTK Query, and approve, publish, delete and assignee changes are mutations that refresh the counts on success. With it off, the Flux store path is unchanged. Contributes to #8774 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
front-end
…fetches on the RTK path A failed lookup now shows the error instead of "feature since deleted", which is kept for a 404. The page no longer refetches and fades on window focus, like the Flux store. Assignee updates take the route id like the other change request calls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…equest store The change request page and publishing from the feature modal now always use RTK Query, so change-requests-store.js and its actions go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
talissoncosta
changed the title
…ne starts Each mutation keeps its last error, so a failed approve stayed on screen after a later successful change. The not-found and error message rules move to requestError.ts, shared by the hook and the query, with unit tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
talissoncosta
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Contributes to #8774
The change request page and publishing from the feature modal stop using the Flux change request store, which is removed:
getChangeRequest,actionChangeRequest(approve and publish) andupdateChangeRequestAssignees. Each mutation refreshes the change request, the sidebar counts and feature states once it succeeds, so a failed follow-up request can no longer leave the page stuck with stale counts.useChangeRequestDetail.change-requests-store.jsand its fourAppActionsare deleted.How did you test this code?
Locally, on a v1 and a v2 (versioned) environment: