Repository navigation
fix(Change requests): Refresh counts once an approve or publish succeeds - #8922
Closed
talissoncosta wants to merge 1 commit into
Closed
talissoncosta wants to merge 1 commit into
talissoncosta wants to merge 1 commit into
Conversation
The refresh only ran after re-reading the change request, and that promise was not returned, so a failed re-read left stale counts, a page stuck loading and no error. Contributes to #8774 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
the
front-end
4 tasks done
Contributor
Author
|
Superseded by #8923, which removes the store this patches. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Contributes to #8774
After approving or publishing a change request, the sidebar counts and feature values only refreshed once a follow-up request for the change request succeeded. That request's promise wasn't returned, so if it failed, the change was published on the server but the page stayed faded, showed no error, and the counts stayed stale until a reload.
Now the refresh runs as soon as the approve or publish succeeds, and a failed follow-up request shows an error instead of hanging.
The proper fix is moving the change request detail page onto RTK Query, like project change requests; that's a separate follow-up.
How did you test this code?
Locally, with the follow-up
GETforced to fail (500) right after publishing: