Skip to content

fix(usage): reword the plan hint when we have no billing period #8430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
talissoncosta wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(usage): reword the plan hint when we have no billing period #8430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/web/components/pages/usage/__tests__/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ describe('UsageDashboard utils', () => {

expect(basis).toEqual({ reason: 'free', window: 'rolling' })
expect(allowanceWindow(basis)).toBeUndefined()
expect(planSectionCopy(basis, 50000).hint).not.toContain(
'no billing period',
expect(planSectionCopy(basis, 50000).hint).toBe(
'Usage against your plan limit over the last 30 days.',
)
})

Expand All @@ -119,7 +119,7 @@ describe('UsageDashboard utils', () => {

expect(basis).toEqual({ reason: 'no-period', window: 'rolling' })
expect(planSectionCopy(basis, 50000).hint).toContain(
'has no billing period',
'unable to show exact billing periods',
)
})
})
Expand Down
2 changes: 1 addition & 1 deletion frontend/web/components/pages/usage/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const planSectionCopy = (
return {
hint: `Usage against your plan limit over ${allowanceWindowLabel(
basis,
)}. This organisation has no billing period.`,
)}. We are unable to show exact billing periods for your subscription plan.`,
title: 'Your plan',
}
}
Expand Down
Loading