Skip to content

fix(usage): reword the plan hint when we have no billing period - #8430

Open
talissoncosta wants to merge 1 commit into
mainfrom
fix/usage-plan-period-copy
Open

fix(usage): reword the plan hint when we have no billing period#8430
talissoncosta wants to merge 1 commit into
mainfrom
fix/usage-plan-period-copy

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

Copy only, follow-up to #8357.

Before:

Usage against your plan limit over the last 30 days. This organisation has no billing period.

After:

Usage against your plan limit over the last 30 days. We are unable to show exact billing periods for your subscription plan.

The old line names an absence in the customer's account, so someone on a contract reads it as something being wrong with theirs. The limitation is ours: we only hold those dates for Chargebee subscriptions.

Free plans are unaffected, they keep the first sentence alone.

How did you test this code?

npm run test:unit -- --testPathPatterns="pages/usage", and the Pages/Usage Dashboard stories in Storybook.

@vercel

vercel Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Sep 1, 2026 4:37pm UTC
flagsmith-frontend-staging Ready Ready Preview Sep 1, 2026 4:37pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Sep 1, 2026 4:37pm UTC

Request Review

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Sep 1, 2026
@github-actions github-actions Bot added the fix label Sep 1, 2026
@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: a16f9b9e-8bfa-4172-b52b-c4a443cf020f

📥 Commits

Reviewing files that changed from the base of the PR and between 76da16c and 4af37f9.

📒 Files selected for processing (2)
  • frontend/web/components/pages/usage/__tests__/utils.test.ts
  • frontend/web/components/pages/usage/utils.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The usage dashboard now uses revised hint text for rolling plans without billing periods. The tests now assert the exact free-plan hint and the updated paid-plan wording.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 4af37

This change only clarifies the usage hint shown when exact billing periods are unavailable; subscription handling and free-plan behavior remain unchanged. No actionable merge-blocking risk remains beyond normal checks and review.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@talissoncosta @claude
fix(usage): reword the plan hint when we have no billing period
4af37f9 
"This organisation has no billing period" names an absence in the
customer's account, so a customer on a contract reads it as something
being wrong with theirs. Matt's wording puts the limitation on us
instead, which is where it belongs: we hold the dates only for
Chargebee subscriptions.

Still shown only to paid organisations. A free plan has no billing
period by design, so there is nothing we are failing to show.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@talissoncosta
talissoncosta force-pushed the fix/usage-plan-period-copy branch from f5d991c to 4af37f9 Compare September 1, 2026 16:36
@talissoncosta talissoncosta changed the title fix(usage): drop the "no billing period" line from the plan hint fix(usage): reword the plan hint when we have no billing period Sep 1, 2026
@github-actions github-actions Bot removed the fix label Sep 1, 2026
@talissoncosta
talissoncosta marked this pull request as ready for review September 1, 2026 16:37
@talissoncosta
talissoncosta requested a review from a team as a code owner September 1, 2026 16:37
@talissoncosta
talissoncosta requested review from kyle-ssg and removed request for a team September 1, 2026 16:37
@github-actions github-actions Bot added the fix label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8430 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8430 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8430 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8430 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8430 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8430 Finished ✅ Results ✅

@github-actions github-actions Bot added fix and removed fix labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #20038 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  36.9 seconds
commit  4af37f9
info  🔄 Run: #20038 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20038 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  37.2 seconds
commit  4af37f9
info  🔄 Run: #20038 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20038 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.9 seconds
commit  4af37f9
info  🔄 Run: #20038 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #20038 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43.9 seconds
commit  4af37f9
info  🔄 Run: #20038 (attempt 1)

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end
@matthewelwell matthewelwell Awaiting requested review from matthewelwell

At least 1 approving review is required to merge this pull request.

Assignees

@matthewelwell matthewelwell

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@talissoncosta @matthewelwell