-
Notifications
You must be signed in to change notification settings - Fork 549
feat: signup corporate-only experiment with exposure and new_signup events #7979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zaimwa9
wants to merge
10
commits into
main
Choose a base branch
from
feat/signup-corporate-only-experiment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
32af124
feat: signup corporate-only experiment with exposure and new_signup e…
Zaimwa9 ed57a05
refactor: simplify signup experiment to explicit exposure tracking
Zaimwa9 d0147c8
refactor: move signup experiment logic into useSignupExperiment hook
Zaimwa9 9af5723
fix: require first and last name before enabling signup
Zaimwa9 f855915
fix: use default events API for Flagsmith-on-Flagsmith events
Zaimwa9 56c672e
chore: show signup experiment variant for debugging
Zaimwa9 71683f0
Revert "chore: show signup experiment variant for debugging"
Zaimwa9 0f99759
feat: include email domain in new_signup metadata for personal emails
Zaimwa9 5fc7532
fix: fallback for crypto.randomUUID on plain-HTTP installs
Zaimwa9 017cd9e
feat: start experiment on free-email detection and track OAuth signups
Zaimwa9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { useEffect, useRef, useState } from 'react' | ||
| import flagsmith from '@flagsmith/flagsmith' | ||
| import isFreeEmailDomain from './utils/isFreeEmailDomain' | ||
| import { storageGet, storageSet } from './safeLocalStorage' | ||
|
|
||
| // The experiment only starts (identify + exposure) once the visitor types a | ||
| // free email domain — corporate-email visitors never enter the experiment. | ||
| export default function useSignupExperiment( | ||
| useEnvironmentFlag: boolean, | ||
| email: string, | ||
| ) { | ||
| const [variant, setVariant] = useState<string>() | ||
| const started = useRef(false) | ||
|
|
||
| useEffect(() => { | ||
| if (useEnvironmentFlag || started.current || !isFreeEmailDomain(email)) { | ||
| return | ||
| } | ||
| started.current = true | ||
| const identifyAndExpose = async () => { | ||
| const id = | ||
| storageGet('signup_anonymous_id') || | ||
| (crypto.randomUUID?.() ?? `${Date.now()}-${Math.random()}`) | ||
| storageSet('signup_anonymous_id', id) | ||
| // @ts-expect-error transient is missing from the SDK's identify type | ||
| await flagsmith.identify(id, {}, true) | ||
| const flag = flagsmith.getExperimentFlag('signup_corporate_only') | ||
| setVariant(flag?.enabled ? flag.variant : undefined) | ||
| } | ||
| identifyAndExpose().catch(() => { | ||
| started.current = false | ||
| }) | ||
| }, [useEnvironmentFlag, email]) | ||
|
|
||
| return variant | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.