feat: signup corporate-only experiment with exposure and new_signup events by Zaimwa9 · Pull Request #7979 · Flagsmith/flagsmith

Zaimwa9 · 2026-07-10T11:07:26Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Sets up our first dogfood experiment, Signup corporate domains only.

The experiment tests whether requiring a work email address at signup affects conversion. Control keeps today's behaviour (an informational message for free email domains); the signup_corporate_only variant disables the Create Account button for free email domains and shows "Please use your work email address to create your account."

Upgrade @flagsmith/flagsmith to 12.1.0 for trackEvent, trackExposureEvent, getExperimentFlag and the variant key on flags.
New useSignupExperiment hook: identifies anonymous signup visitors with a transient identity (persistent signup_anonymous_id so returning visitors keep their variant), resolves the signup_corporate_only flag's variant, and records a $flag_exposure. Takes a boolean to fall back to environment flags — no identify, no exposure, control experience — for non-participants (invitees, login views, logged-in users, preventEmailPassword).
new_signup conversion event on successful registration, attributed to the same anonymous identity, with free_email_domain, invite, signup_method and utm_source metadata.
Signup button now also requires non-blank first and last names.

How did you test this code?

Manually, against the staging configuration with the flag and experiment set up:

Open /signup logged out — the network tab shows identities/?identifier=<uuid>&transient=true, followed (≤10s) by a POST /v1/events containing a $flag_exposure with the variant as value (verified 202).
In the treatment variant, entering a gmail.com address disables Create Account and shows the work-email message; a work domain enables it. Control behaviour is unchanged.
Completing a signup sends new_signup with the same identifier and metadata.
Invite links and the login view trigger no identify/exposure and always get control.
Variant bucketing verified ~50/50 across identifiers against the identities API; unit tests (236) and typecheck pass.

…vents

This reverts commit 56c672e.

vercel · 2026-07-10T11:07:32Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ready	Preview, Comment	Jul 10, 2026 11:10am
flagsmith-frontend-staging	Ready	Preview, Comment	Jul 10, 2026 11:10am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Jul 10, 2026 11:10am

coderabbitai · 2026-07-10T11:08:22Z

📝 Walkthrough

Walkthrough

The signup flow now records Flagsmith new_signup events with registration metadata. A new hook persists an anonymous identifier and reads the signup_corporate_only experiment variant. The homepage uses that variant to block free email domains, display work-email guidance, and disable account creation. The Flagsmith frontend dependency is updated to version 12.1.0.

Estimated code review effort: 3 (Moderate) | ~20 minutes

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-10T11:08:30Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api-test:pr-7979`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api-test:pr-7979`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-7979`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api:pr-7979`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7979`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7979`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7979`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-7979`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7979`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-e2e:pr-7979`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-frontend:pr-7979`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-e2e:pr-7979`	Finished ✅	Skipped

github-actions · 2026-07-10T11:15:36Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

4 passed

Details

4 tests across 3 suites
35.1 seconds
0f99759
🔄 Run: #18155 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

3 passed

Details

3 tests across 3 suites
46.5 seconds
71683f0
🔄 Run: #18154 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

4 passed

Details

4 tests across 3 suites
46 seconds
0f99759
🔄 Run: #18155 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

5 passed

Details

5 tests across 4 suites
47.1 seconds
71683f0
🔄 Run: #18154 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

7 passed

Details

7 tests across 5 suites
12 seconds
0f99759
🔄 Run: #18155 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
47.4 seconds
0f99759
🔄 Run: #18155 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
59.3 seconds
71683f0
🔄 Run: #18154 (attempt 1)

github-actions · 2026-07-10T11:15:36Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

4 passed

Details

4 tests across 3 suites
34.1 seconds
71683f0
🔄 Run: #18154 (attempt 1)

github-actions · 2026-07-10T11:16:20Z

Visual Regression

19 screenshots compared. See report for details.
View full report

coderabbitai

Actionable comments posted: 5

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a04fcc89-95a6-4ac2-aec1-a2a6a17d5749

📥 Commits

Reviewing files that changed from the base of the PR and between a7b0d21 and 0f99759.

⛔ Files ignored due to path filters (1)

frontend/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (4)

frontend/common/stores/account-store.js
frontend/common/useSignupExperiment.ts
frontend/package.json
frontend/web/components/pages/HomePage.tsx

Zaimwa9 added 7 commits July 9, 2026 16:46

feat: signup corporate-only experiment with exposure and new_signup e…

32af124

…vents

refactor: simplify signup experiment to explicit exposure tracking

ed57a05

refactor: move signup experiment logic into useSignupExperiment hook

d0147c8

fix: require first and last name before enabling signup

9af5723

fix: use default events API for Flagsmith-on-Flagsmith events

f855915

chore: show signup experiment variant for debugging

56c672e

Revert "chore: show signup experiment variant for debugging"

71683f0

This reverts commit 56c672e.

Zaimwa9 requested a review from a team as a code owner July 10, 2026 11:07

Zaimwa9 requested review from talissoncosta and removed request for a team July 10, 2026 11:07

github-actions Bot added the front-end Issue related to the React Front End Dashboard label Jul 10, 2026

github-actions Bot added the feature New feature or request label Jul 10, 2026

feat: include email domain in new_signup metadata for personal emails

0f99759

github-actions Bot removed the feature New feature or request label Jul 10, 2026

vercel Bot deployed to Preview – flagsmith-frontend-preview July 10, 2026 11:10 View deployment

github-actions Bot added the feature New feature or request label Jul 10, 2026

vercel Bot deployed to Preview – flagsmith-frontend-staging July 10, 2026 11:10 View deployment

coderabbitai Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread frontend/common/useSignupExperiment.ts

Comment thread frontend/common/useSignupExperiment.ts

Comment thread frontend/common/useSignupExperiment.ts

Comment thread frontend/web/components/pages/HomePage.tsx

Comment thread frontend/web/components/pages/HomePage.tsx

Zaimwa9 assigned talissoncosta Jul 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: signup corporate-only experiment with exposure and new_signup events#7979

feat: signup corporate-only experiment with exposure and new_signup events#7979
Zaimwa9 wants to merge 8 commits into
mainfrom
feat/signup-corporate-only-experiment

Zaimwa9 commented Jul 10, 2026

Uh oh!

vercel Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

Walkthrough

Uh oh!

github-actions Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Zaimwa9 commented Jul 10, 2026

Changes

How did you test this code?

Uh oh!

vercel Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

github-actions Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

github-actions Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

github-actions Bot commented Jul 10, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Uh oh!

github-actions Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Jul 10, 2026 •

edited

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

github-actions Bot commented Jul 10, 2026 •

edited

Loading

github-actions Bot commented Jul 10, 2026 •

edited

Loading

github-actions Bot commented Jul 10, 2026 •

edited

Loading