Skip to content

feat: Support getExperimentFlag, trackEvent and trackExposure methods - #127

Merged
gagantrivedi merged 7 commits into
mainfrom
openhands/sdk-spec-v0.7.1
Nov 9, 2026
Merged

feat: Support getExperimentFlag, trackEvent and trackExposure methods#127
gagantrivedi merged 7 commits into
mainfrom
openhands/sdk-spec-v0.7.1

Conversation

@flagsmithsmith

@flagsmithsmith flagsmithsmith Bot commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Contributes to Flagsmith/sdk-spec#13

renovate Bot and others added 2 commits November 5, 2026 17:35
@renovate
deps: update dependency flagsmith/sdk-spec to v0.7.1
1bbde24
@flagsmith-engineering
ci: Run the SDK spec for this SDK's capabilities
d507238 
Its entry in Flagsmith/sdk-spec's compatibility matrix at v0.7.1: `core or events or local-evaluation`.
@flagsmithsmith flagsmithsmith Bot added the sdk-spec Bumps of the Flagsmith SDK behavioural spec label Nov 5, 2026
@flagsmithsmith flagsmithsmith Bot mentioned this pull request Nov 5, 2026
Closed
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 981022eb-7bd5-405f-84da-4f2571e78dfc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codspeed

codspeed Bot commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks

Comparing openhands/sdk-spec-v0.7.1 (02a2389) with main (a6ccd7f)

Open in CodSpeed

flagsmithsmith Bot and others added 3 commits November 5, 2026 20:11
@flagsmithsmith @claude
feat: Experiment flags, tracking events and exposure events
7489c5e 
Implements SDK spec v0.6.0's getExperimentFlag, trackEvent and
trackExposureEvent. With `enable_events: true`, the client buffers events
and sends them in batches to the Flagsmith events API (`events_api_url`).
`get_experiment_flag` records an identity's exposure to the variant it was
served when it is in the feature's running experiment, which flags now
expose as `variant` and `experiment`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 3ec4437)
@flagsmithsmith @claude
fix: Schedule at most one flush when the event buffer is full
a59d16e 
A slow or failing events API request held the flush lock while every
further event past the buffer limit started another flush thread.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 2526c08)
@flagsmithsmith @claude
fix: Release stopped event processors and keep identifiers out of logs
795dff1 
- Stop running event processors at exit from one registry that a
  stopped processor leaves, instead of an at_exit block per start that
  kept every processor in memory.
- Drop the identifier from the duplicate exposure debug log.
- Give the accurate reason when get_experiment_flag skips an exposure
  because flags come from the environment document, which carries no
  experiment data.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit f829d07)
@flagsmithsmith

flagsmithsmith Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

The spec run was red because v0.7.1's compatibility matrix adds the events capability for this SDK, and the SDK had no event tracking: the 5 @events scenarios failed on the missing Create the SDK client with events enabled step. The other v0.7.1 change, empty-string flag values, already passed.

I re-applied the earlier event tracking work:

  • 7489c5e (from 793e104) adds enable_events / events_api_url, track_event, track_exposure_event and get_experiment_flag. Exposures are recorded when the identity is in the feature's running experiment, and flags now carry variant and experiment. Events are buffered and sent in batches to the events API.
  • a59d16e (from 34bf7c5) schedules at most one flush when the event buffer is full.
  • 795dff1 (from 4751d17) releases stopped event processors and keeps identifiers out of logs.

The only conflict was in sdk-spec/steps.rb. Since that work was written, main gained create_client_with_local_evaluation. I kept it next to the new create_client_with_events. The steps only call the SDK.

Checks run locally:

  • bundle exec rubocop: no offences.
  • bundle exec rspec spec: 430 examples, 0 failures.
  • The v0.7.1 spec with core or events or local-evaluation: 9 passed, three runs in a row on an isolated stack.

@flagsmithsmith
flagsmithsmith Bot marked this pull request as ready for review November 5, 2026 21:02
@flagsmithsmith
flagsmithsmith Bot requested a review from a team as a code owner November 5, 2026 21:02
@flagsmithsmith
flagsmithsmith Bot requested review from emyller and removed request for a team November 5, 2026 21:02
@flagsmithsmith flagsmithsmith Bot mentioned this pull request Nov 5, 2026
Open
@flagsmithsmith flagsmithsmith Bot changed the title feat: Implement SDK spec v0.7.1 feat: Support getExperimentFlag, trackEvent and trackExposure methods Nov 6, 2026
gagantrivedi
gagantrivedi requested changes Nov 9, 2026
View reviewed changes
Comment thread lib/flagsmith.rb Resolved
Comment thread lib/flagsmith/sdk/event_processor.rb Resolved
Comment thread lib/flagsmith/sdk/event_processor.rb Resolved
flagsmithsmith Bot and others added 2 commits November 9, 2026 08:55
@flagsmithsmith @claude
fix: Reject enable_events in offline mode
1030339 
Offline mode makes no network calls, but a client created with both
offline_mode and enable_events still sent events to the events API.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@flagsmithsmith @claude
refactor: Keep the scheduled flush out of EventProcessor#flush
02a2389 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@flagsmithsmith
flagsmithsmith Bot requested a review from gagantrivedi November 9, 2026 09:01
@gagantrivedi
gagantrivedi merged commit 670b413 into main Nov 9, 2026
10 checks passed
@flagsmithdev flagsmithdev mentioned this pull request Nov 9, 2026
Merged
gagantrivedi pushed a commit that referenced this pull request Nov 9, 2026
@flagsmithdev
chore(main): release 5.2.0 (#124)
e968b8c 
🤖 I have created a release *beep* *boop*
---


##
[5.2.0](v5.1.0...v5.2.0)
(2026-11-09)


### Features

* Support `getExperimentFlag`, `trackEvent` and `trackExposure` methods
([#127](#127))
([670b413](670b413))


### Bug Fixes

* Serve multivariate segment overrides their variant under local
evaluation
([#128](#128))
([dbb7a83](dbb7a83))


### Other

* Let Renovate keep updating spec bumps the webhook handler commits to
([#123](#123))
([a6ccd7f](a6ccd7f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gagantrivedi gagantrivedi gagantrivedi approved these changes
@emyller emyller Awaiting requested review from emyller emyller is a code owner automatically assigned from Flagsmith/flagsmith-back-end

Assignees

@emyller emyller

@gagantrivedi gagantrivedi

Labels

sdk-spec Bumps of the Flagsmith SDK behavioural spec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gagantrivedi @emyller