Repository navigation
feat: Implement SDK spec v0.7.0 - #125
Closed
flagsmithsmith[bot] wants to merge 4 commits into
Closed
flagsmithsmith[bot] wants to merge 4 commits into
flagsmithsmith[bot] wants to merge 4 commits into
Conversation
Implements SDK spec v0.6.0's getExperimentFlag, trackEvent and trackExposureEvent. With `enable_events: true`, the client buffers events and sends them in batches to the Flagsmith events API (`events_api_url`). `get_experiment_flag` records an identity's exposure to the variant it was served when it is in the feature's running experiment, which flags now expose as `variant` and `experiment`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 3ec4437)
A slow or failing events API request held the flush lock while every further event past the buffer limit started another flush thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 2526c08)
- Stop running event processors at exit from one registry that a stopped processor leaves, instead of an at_exit block per start that kept every processor in memory. - Drop the identifier from the duplicate exposure debug log. - Give the accurate reason when get_experiment_flag skips an exposure because flags come from the environment document, which carries no experiment data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f829d07)
1 task
|
Important Review skippedBot user detected. To trigger a single review, invoke the
 |
Contributor
Author
|
Superseded by #127, which carries this pull request's implementation work, for the SDK spec's latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the SDK spec's v0.7.0 in this SDK.
This pull request was opened by an AI agent (OpenHands).