Skip to content

fix(core): Prevent crash in cleanMessageData on null message #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moothz wants to merge 1 commit into from
+5 −6
Closed

fix(core): Prevent crash in cleanMessageData on null message #2159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/api/services/channel.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,11 +535,10 @@ export class ChannelStartupService {

const cleanedMessage = { ...message };

const mediaUrl = cleanedMessage.message.mediaUrl;

delete cleanedMessage.message.base64;

if (cleanedMessage.message) {
const mediaUrl = cleanedMessage.message.mediaUrl;
Copy link
Contributor

@sourcery-ai sourcery-ai bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code-quality): Prefer object destructuring when accessing and using properties. (use-object-destructuring)

Suggested change
const mediaUrl = cleanedMessage.message.mediaUrl;
const {mediaUrl} = cleanedMessage.message;


ExplanationObject destructuring can often remove an unnecessary temporary reference, as well as making your code more succinct.

From the Airbnb Javascript Style Guide

delete cleanedMessage.message.base64;

// Limpa imageMessage
if (cleanedMessage.message.imageMessage) {
cleanedMessage.message.imageMessage = {
Expand Down Expand Up @@ -581,9 +580,9 @@ export class ChannelStartupService {
name: cleanedMessage.message.documentWithCaptionMessage.name,
};
}
}

if (mediaUrl) cleanedMessage.message.mediaUrl = mediaUrl;
if (mediaUrl) cleanedMessage.message.mediaUrl = mediaUrl;
}

return cleanedMessage;
}
Expand Down
Loading