fix(core): Prevent crash in cleanMessageData on null message

[moothz]

📋 Description

Modificação simples que previne erros de acesso à propriedades não definidas de objetos, que interrompem o fluxo do /chat/findChats e fazem com o que os chats no manager não sejam carregados.

Resolve esses erros:

• No manager, acessando os chats da instancia: 'The application is taking longer than expected to load, please try again in a few minutes.'
• /chat/findChats: Cannot read properties of null (reading 'mediaUrl')
• /chat/findChats: Cannot convert undefined or null to object

🔗 Related Issue

Closes #2058

🧪 Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📚 Documentation update
• 🔧 Refactoring (no functional changes)
• ⚡ Performance improvement
• 🧹 Code cleanup
• 🔒 Security fix

🧪 Testing

• Manual testing completed
• Functionality verified in development environment
• No breaking changes introduced
• Tested with different connection types (if applicable)

✅ Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have manually tested my changes thoroughly
• I have verified the changes work with different scenarios
• Any dependent changes have been merged and published

Summary by Sourcery

Bug Fixes:

• Add null check around cleanedMessage.message to avoid reading mediaUrl and base64 on null, fixing crashes in /chat/findChats and chat manager.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduce null checks in cleanMessageData to prevent property-access crashes and correctly maintain mediaUrl during message cleaning by restructuring the extraction and restoration steps within the message existence guard.

Sequence diagram for cleanMessageData null-safe message cleaning

sequenceDiagram
participant S as "ChannelStartupService"
participant M as "message (input)"
participant C as "cleanedMessage (output)"
S->>M: Receives message
alt message exists
    S->>M: Extract mediaUrl
    S->>M: Delete base64
    S->>M: Clean imageMessage
    S->>M: Clean documentWithCaptionMessage
    S->>M: Restore mediaUrl if present
else message is null
    S->>C: Return cleanedMessage unchanged
end

Loading

Class diagram for updated ChannelStartupService.cleanMessageData

classDiagram
class ChannelStartupService {
  +cleanMessageData(message)
}
class Message {
  mediaUrl
  base64
  imageMessage
  documentWithCaptionMessage
}
class ImageMessage {
  caption
  mimetype
  name
}
class DocumentWithCaptionMessage {
  caption
  mimetype
  name
}
ChannelStartupService --> Message
Message --> ImageMessage
Message --> DocumentWithCaptionMessage

Loading

File-Level Changes

Change	Details	Files
Guarded message property access and reorganized mediaUrl handling	Moved mediaUrl extraction and base64 deletion inside the cleanedMessage.message existence check Removed redundant pre-check mediaUrl assignment and separate base64 deletion Restored mediaUrl conditionally after cleaning within the same guard block	src/api/services/channel.service.ts

Possibly linked issues

• [BUG]Erro 500 na listagem de Chats #2058: The PR fixes the 500 error on /chat/findChats by preventing null message property access in cleanMessageData.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider doing an early return when cleanedMessage.message is falsy to avoid deep nesting and make the intent clearer.
• You could simplify the null checks with optional chaining (e.g. cleanedMessage.message?.mediaUrl) to reduce mutable assignments and improve readability.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider doing an early return when `cleanedMessage.message` is falsy to avoid deep nesting and make the intent clearer.
- You could simplify the null checks with optional chaining (e.g. `cleanedMessage.message?.mediaUrl`) to reduce mutable assignments and improve readability.

## Individual Comments

### Comment 1
<location> `src/api/services/channel.service.ts:539` </location>
<code_context>
      const mediaUrl = cleanedMessage.message.mediaUrl;

</code_context>

<issue_to_address>
**suggestion (code-quality):** Prefer object destructuring when accessing and using properties. ([`use-object-destructuring`](https://docs.sourcery.ai/Reference/Rules-and-In-Line-Suggestions/TypeScript/Default-Rules/use-object-destructuring))

```suggestion
      const {mediaUrl} = cleanedMessage.message;
```

<br/><details><summary>Explanation</summary>Object destructuring can often remove an unnecessary temporary reference, as well as making your code more succinct.

From the [Airbnb Javascript Style Guide](https://airbnb.io/javascript/#destructuring--object)
</details>
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (code-quality): Prefer object destructuring when accessing and using properties. (use-object-destructuring)

Suggested change

	const mediaUrl = cleanedMessage.message.mediaUrl;
	const {mediaUrl} = cleanedMessage.message;

Explanation

Object destructuring can often remove an unnecessary temporary reference, as well as making your code more succinct.

From the Airbnb Javascript Style Guide

[moothz]

Vi agora no discord que falaram que já está feito esse fix, não sendo necessário meu PR. Criei um novo na /develop