fix: declare the MIT licence the repository already carries - #24
Merged
Conversation
Every push to nuget.org warns "License missing" and the published package carries no licence expression, so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read. The repository has shipped an MIT LICENSE all along. One of eight: the same line was missing from every published Evergine.Bindings package. Each repository's own LICENSE was checked rather than assumed before writing MIT here.
The first version of this change read the file as utf-8-sig and wrote it back as plain utf-8, which silently dropped the BOM and turned a one-line addition into a two-line diff. Restored: the only change is now the licence line.
jcant0n
added a commit
to EvergineTeam/evergine-standards
that referenced
this pull request
Sep 1, 2026
The copyright year was written by hand in one file, so every January it went
stale in fourteen repositories at once. LICENSE is now distributed from
templates/LICENSE, which holds `Copyright (c) {{YEAR}} Evergine`, and the sync
expands the token as it writes.
Substitution is opt-in per manifest entry ("substitute": true), not global.
Every other file keeps going through Get-SourceBytes and WriteAllBytes
untouched -- that byte-exact copy is what makes the sync idempotent and its
diffs readable, and expanding assets/nuget-icon.png or the PowerShell helpers
would risk them for no gain.
Two details the implementation is careful about:
A byte order mark, and the file's line endings, survive. Reading as utf-8-sig
and writing back plain utf-8 drops the BOM and turns a one-line change into a
whole-file diff -- the mistake EvergineTeam/WebGPU.NET#24 had to correct. A
file with no tokens comes through byte-identical even when marked.
The year arrives as -Year rather than a bare Get-Date, so tests pin it instead
of depending on when the suite runs. The integration case uses -Year 2099 and
is a real run, not a dry run, because what matters is what lands on disk.
The placeholder does not go in this repository's own LICENSE: a licence file
containing {{YEAR}} is not a licence. LICENSE stays real and the sync reads the
template beside it.
Rolling this out changes nothing visible today -- {{YEAR}} renders 2026 and all
fourteen repositories already say 2026, so the correct outcome is zero commits.
Verified against WebGPU.NET's live LICENSE: byte-identical.
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 1, 2026
jcant0n
added a commit
to EvergineTeam/MuJoCo.NET
that referenced
this pull request
Sep 1, 2026
Every push to nuget.org warns "License missing" and the published package carries no licence expression, so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read. EvergineTeam/WebGPU.NET#24 fixed this across the eight repositories that existed on 8 August. This one was created on the 10th and missed the sweep; Tracy.NET and Thorvg.NET are in the same position. MIT describes the binding code, which is what the expression is for. The native library is Apache-2.0 and its binaries ship under runtimes/, so the notice now travels with them -- the pattern Tracy.NET and Thorvg.NET already use. Upstream has no NOTICE file, so Apache-2.0 section 4(d) adds nothing further here. The Apache-2.0 boilerplate names no licensor, unlike the MIT and BSD texts the other two repositories ship, so the file opens with a two-line attribution in the style of Tracy-LICENSE.txt. Deliberately without a version number: binding.yml already records the pinned release and binding-fetch-upstream rewrites it, so a number here would go stale in silence. Verified by packing locally and opening the nupkg: the nuspec carries <license type="expression">MIT</license> and THIRD-PARTY-LICENSE-mujoco.txt sits at the package root. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
jcant0n
added a commit
to EvergineTeam/Tracy.NET
that referenced
this pull request
Sep 1, 2026
Every push to nuget.org warns "License missing" and the published package carries no licence expression, so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read. EvergineTeam/WebGPU.NET#24 fixed this across the eight repositories that existed on 8 August. This one was created afterwards and missed the sweep; MuJoCo.NET and the other new binding are in the same position. MIT describes the binding code, which is what the expression is for. Tracy's own licence is unaffected and its notice already travels with the binaries in Tracy-LICENSE.txt -- nothing to add there. Verified by packing locally and opening the nupkg: the nuspec carries <license type="expression">MIT</license> and Tracy-LICENSE.txt still sits at the package root. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
jcant0n
added a commit
to EvergineTeam/Thorvg.NET
that referenced
this pull request
Sep 1, 2026
Every push to nuget.org warns "License missing" and the published package carries no licence expression, so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read. EvergineTeam/WebGPU.NET#24 fixed this across the eight repositories that existed on 8 August. This one was created afterwards and missed the sweep; MuJoCo.NET and the other new binding are in the same position. MIT describes the binding code, which is what the expression is for. ThorVG's own licence is unaffected and its notice already travels with the binaries in THIRD-PARTY-LICENSE-thorvg.txt -- nothing to add there. Verified by packing locally and opening the nupkg: the nuspec carries <license type="expression">MIT</license> and THIRD-PARTY-LICENSE-thorvg.txt still sits at the package root. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every push to nuget.org warns
License missingand the published package carries no licence expression, so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read. The repository has shipped an MITLICENSEall along.One of eight: the same line was missing from every published
Evergine.Bindingspackage. Each repository's ownLICENSEwas read and confirmed MIT before writing it here, rather than assumed.Verified on Cesium.NET by packing locally, where the nuspec then carried
<license type="expression">MIT</license>.