fix: declare the package licence - #7
Merged
Merged
Conversation
Every push to nuget.org warns "License missing" and the published package carries no licence expression, so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read. EvergineTeam/WebGPU.NET#24 fixed this across the eight repositories that existed on 8 August. This one was created afterwards and missed the sweep; MuJoCo.NET and the other new binding are in the same position. MIT describes the binding code, which is what the expression is for. ThorVG's own licence is unaffected and its notice already travels with the binaries in THIRD-PARTY-LICENSE-thorvg.txt -- nothing to add there. Verified by packing locally and opening the nupkg: the nuspec carries <license type="expression">MIT</license> and THIRD-PARTY-LICENSE-thorvg.txt still sits at the package root. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every push to nuget.org warns
License missing, and the published package carries no licence expression — so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read.EvergineTeam/WebGPU.NET#24 fixed this across the eight repositories that existed on 8 August. This one was created afterwards and missed the sweep. Companion PRs go out to the other three in the same position.
<RepositoryUrl>https://github.com/EvergineTeam/Thorvg.NET</RepositoryUrl> + <PackageLicenseExpression>MIT</PackageLicenseExpression> <PackageIcon>icon.png</PackageIcon>MIT describes the binding code, which is what the expression is for. The native library's own licence is unaffected, and its notice already travels with the binaries — nothing to add there.
Only the project that publishes a package is touched; the generator, demos and tests are left alone. There is no
Directory.Build.propsin this repository, so the csproj is the only place this can be declared.Verified, not assumed
Packed locally with the .NET 10 SDK and opened the
.nupkg:Byte hygiene checked too — no BOM introduced, LF preserved, tabs preserved. That is the mistake WebGPU.NET#24 had to correct in its own second commit.
🤖 Generated with Claude Code