Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 27.39% 27.40% +0.01%
==========================================
Files 78 78
Lines 10138 10140 +2
Branches 1333 1332 -1
==========================================
+ Hits 2777 2779 +2
Misses 7266 7266
Partials 95 95 |
d-j-hatton
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client-side TUI was requesting for the machine config using a server API endpoint that relied on the server having a pre-defined BEAMLINE environment variable, which is something we're moving away from. This PR replaces those endpoint requests with the one that loads the machine config that matches the client's instrument name.
Also fixes minor broken logic prevent the visit creation screen from working, and adds a log to report on the rsync remote path being used.
Verification checks: