Change how we use the rsync module specified in the machine configuration#476
Merged
d-j-hatton merged 3 commits intomainfrom Jan 31, 2025
Merged
Change how we use the rsync module specified in the machine configuration#476d-j-hatton merged 3 commits intomainfrom
d-j-hatton merged 3 commits intomainfrom
Conversation
… base path in the machine configuration
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
- Coverage 27.31% 27.31% -0.01%
==========================================
Files 78 78
Lines 10159 10161 +2
Branches 1338 1338
==========================================
Hits 2775 2775
- Misses 7288 7290 +2
Partials 96 96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we assume that the rsync module name forms part of the path but this isn't necessarily the case. We should specify the whole rsync module path as the
rsync_basepathin the configuration and insert the module name directly where we need it (at the point of construction of thersynccommand).