Skip to content

fix: map KICS critical severity #15357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kocaemre wants to merge 1 commit into
base: dev
Choose a base branch
from
+32 −0
Open

fix: map KICS critical severity #15357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dojo/tools/kics/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class KICSParser:

# table to match KICS severity to DefectDojo severity
SEVERITY = {
"CRITICAL": "Critical",
"HIGH": "High",
"MEDIUM": "Medium",
"LOW": "Low",
Expand Down
31 changes: 31 additions & 0 deletions unittests/tools/test_kics_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
import io
import json

from dojo.models import Test
from dojo.tools.kics.parser import KICSParser
from unittests.dojo_test_case import DojoTestCase, get_unit_tests_scans_path
Expand All @@ -11,6 +14,34 @@ def test_parse_no_findings(self):
findings = parser.get_findings(testfile, Test())
self.assertEqual(0, len(findings))

def test_parse_critical_severity(self):
payload = {
"queries": [
{
"query_name": "Critical IaC Issue",
"query_url": "https://kics.io/",
"severity": "CRITICAL",
"platform": "Terraform",
"category": "Access Control",
"description": "Critical issue description.",
"files": [
{
"file_name": "main.tf",
"line": 7,
"issue_type": "IncorrectValue",
"expected_value": "secure value",
"actual_value": "insecure value",
},
],
},
],
}
parser = KICSParser()
findings = parser.get_findings(io.StringIO(json.dumps(payload)), Test())

self.assertEqual(1, len(findings))
self.assertEqual("Critical", findings[0].severity)

def test_parse_many_findings(self):
with (get_unit_tests_scans_path("kics") / "many_findings.json").open(encoding="utf-8") as testfile:
parser = KICSParser()
Expand Down