fix: map KICS critical severity#15357
Open
kocaemre wants to merge 1 commit into
Open
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRITICALfindings as DefectDojoCriticalinstead of falling through to theMediumdefault.Why
The KICS parser severity map did not include
CRITICAL, so KICS reports with"severity": "CRITICAL"were imported as Medium findings. This can understate IaC risk in dashboards, filters, reports, and SLA workflows.Fixes #15345.
Test plan
python3 -m py_compile dojo/tools/kics/parser.py unittests/tools/test_kics_parser.pyFinding/settings confirmedCRITICALmaps toCriticalgit diff --checkI did not run the full Docker-backed unit test suite in this local environment.