Skip to content

Move AI orchestration runtime out of phases#23916

Open
luisorofino wants to merge 2 commits into
loa/solid-refactorfrom
loa/orchestrator-isolation
Open

Move AI orchestration runtime out of phases#23916
luisorofino wants to merge 2 commits into
loa/solid-refactorfrom
loa/orchestrator-isolation

Conversation

@luisorofino
Copy link
Copy Markdown
Contributor

@luisorofino luisorofino commented Jun 2, 2026

What does this PR do?

Moves AI flow runtime concerns out of the phases package and into a dedicated runtime layer:

  • Moves PhaseOrchestrator to ddev.ai.runtime.orchestrator.
  • Moves checkpoint handling to ddev.ai.runtime.checkpoints.
  • Extracts concrete run-scoped resources into ddev.ai.runtime.resources.RunResources.
  • Extracts phase registration and discovery into ddev.ai.phases.registry.
  • Adds a PhaseResources protocol in ddev.ai.phases.resources so phase implementations depend on a small resource contract instead of the concrete orchestrator module.
  • Updates imports and tests to match the new package boundaries.

Motivation

The AI framework now has clearer responsibility boundaries: phases define executable phase behavior, while runtime owns orchestration, checkpoints, and run-scoped resource wiring. This also improves dependency direction: the runtime layer depends on phases, and phases depend only on the PhaseResources protocol rather than the orchestrator implementation.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@luisorofino luisorofino added the qa/skip-qa Automatically skip this PR for the next QA label Jun 2, 2026
@dd-octo-sts dd-octo-sts Bot added the ddev label Jun 2, 2026
@luisorofino luisorofino changed the title Move orchestrator and checkpoints to ddev/ai/runtime and move resourc… Move AI orchestration runtime out of phases Jun 2, 2026
@datadog-prod-us1-4
Copy link
Copy Markdown
Contributor

datadog-prod-us1-4 Bot commented Jun 2, 2026

Pipelines  Tests  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 6 Pipeline jobs failed

PR | test / check   View in Datadog   GitHub Actions

PR All | test / j06ca546 / SNMP   View in Datadog   GitHub Actions

See error Max retries exceeded with url: /snmp/cisco-3850.snmprec due to failed name resolution of 'ddintegrations.blob.core.windows.net'.

PR All | test / j46da136 / JBoss_WildFly   View in Datadog   GitHub Actions

See error Connection failure: Could not resolve ddintegrations.blob.core.windows.net:443

View all 6 failed jobs.

🧪 20 Tests failed in 1 job

PR All | run   GitHub Actions

test_bulk_table from test_check.py   View in Datadog (Fix with Cursor)
HTTPSConnectionPool(host=&#39;ddintegrations.blob.core.windows.net&#39;, port=443): Max retries exceeded with url: /snmp/cisco-3850.snmprec (Caused by NameResolutionError(&#34;HTTPSConnection(host=&#39;ddintegrations.blob.core.windows.net&#39;, port=443): Failed to resolve &#39;ddintegrations.blob.core.windows.net&#39; ([Errno -2] Name or service not known)&#34;))
test_cast_metrics from test_check.py   View in Datadog (Fix with Cursor)
HTTPSConnectionPool(host=&#39;ddintegrations.blob.core.windows.net&#39;, port=443): Max retries exceeded with url: /snmp/cisco-3850.snmprec (Caused by NameResolutionError(&#34;HTTPSConnection(host=&#39;ddintegrations.blob.core.windows.net&#39;, port=443): Failed to resolve &#39;ddintegrations.blob.core.windows.net&#39; ([Errno -2] Name or service not known)&#34;))

View all 20 test failures

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 96.20%
Overall Coverage: 88.02% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 172b8e4 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown
Contributor Author

luisorofino commented Jun 3, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@luisorofino luisorofino force-pushed the loa/solid-refactor branch from fec8bb0 to fd4614c Compare June 3, 2026 14:24
@luisorofino luisorofino force-pushed the loa/orchestrator-isolation branch from 4684d6f to 172b8e4 Compare June 3, 2026 14:24
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 3, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant