Skip to content

Replace extra_init_kwargs with polymorphic Phase.build() factory and ResourceProvider#23889

Open
luisorofino wants to merge 2 commits into
loa/openmetrics-ai-genfrom
loa/build-phase
Open

Replace extra_init_kwargs with polymorphic Phase.build() factory and ResourceProvider#23889
luisorofino wants to merge 2 commits into
loa/openmetrics-ai-genfrom
loa/build-phase

Conversation

@luisorofino
Copy link
Copy Markdown
Contributor

@luisorofino luisorofino commented Jun 1, 2026

What does this PR do?

Replaces the untyped extra_init_kwargs dict-merge construction path with a typed, polymorphic Phase.build() factory fed by a ResourceProvider. Every phase is now constructed through one uniform call — phase_cls.build(phase_id, config, deps, resources, checkpoint_manager, context) — with no dict splat, no type: ignore[override], and no orchestrator knowledge of how each phase assembles its agent or tools.

Concretely:

  • Phase.build() — new polymorphic classmethod factory on the base class; AgenticPhase overrides it to source agent/tool builders from the provider
  • ResourceProvider — new class in orchestrator.py that serves raw infrastructure (agent clients, file registry singleton, agent configs) to phases during construction; typed ResourceUnavailableError on unknown names
  • FlowContext — replaces FlowServices; holds only the ambient, non-resource half (variables, config_dir, callbacks, logger); checkpoint_manager and file_registry are no longer bundled here
  • PhaseRegistry — moved from base.py to orchestrator.py where it is exclusively used
  • extra_init_kwargs and its type: ignore[override] suppression are removed entirely

This is a construction-seam refactor only. Flow YAML schema, phase runtime behavior, and generated-integration output are unchanged.

Motivation

Tracked in AI-6918.

The old extra_init_kwargs hook was a dict bag that required the orchestrator to merge kwargs it did not understand, forced subclasses to re-declare and re-validate inputs the base class had already validated, and needed a type: ignore[override] to suppress a legitimate Mypy violation. Any new phase that needed extra resources had to either fit into the existing bag or widen the bag further.

Phase.build() gives each phase class full ownership of its construction: it decides what it needs from the provider, assembles the right builders, and returns a fully-initialized instance. The orchestrator loop stays uniform and type-clean regardless of how complex a phase's construction is.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@luisorofino luisorofino added the qa/skip-qa Automatically skip this PR for the next QA label Jun 1, 2026
@dd-octo-sts dd-octo-sts Bot added the ddev label Jun 1, 2026
@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented Jun 1, 2026

Pipelines  Tests  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 5 Pipeline jobs failed

PR All | test / j06ca546 / SNMP   View in Datadog   GitHub Actions

See error Max retries exceeded for HTTPS connection to 'ddintegrations.blob.core.windows.net'. Failed to resolve host name.

PR All | test / j46da136 / JBoss_WildFly   View in Datadog   GitHub Actions

See error Connection refused: Could not resolve 'ddintegrations.blob.core.windows.net:443'.

PR All | test / j5a9585a / IBM ACE   View in Datadog   GitHub Actions

See error Cannot open the file './*.tar.gz': No such file or directory, causing tar command to exit with status 2.

View all 5 failed jobs.

🧪 20 Tests failed in 1 job

PR All | run   GitHub Actions

test_bulk_table from test_check.py   View in Datadog (Fix with Cursor)
HTTPSConnectionPool(host=&#39;ddintegrations.blob.core.windows.net&#39;, port=443): Max retries exceeded with url: /snmp/cisco-3850.snmprec (Caused by NameResolutionError(&#34;HTTPSConnection(host=&#39;ddintegrations.blob.core.windows.net&#39;, port=443): Failed to resolve &#39;ddintegrations.blob.core.windows.net&#39; ([Errno -2] Name or service not known)&#34;))
test_cast_metrics from test_check.py   View in Datadog (Fix with Cursor)
HTTPSConnectionPool(host=&#39;ddintegrations.blob.core.windows.net&#39;, port=443): Max retries exceeded with url: /snmp/cisco-3850.snmprec (Caused by NameResolutionError(&#34;HTTPSConnection(host=&#39;ddintegrations.blob.core.windows.net&#39;, port=443): Failed to resolve &#39;ddintegrations.blob.core.windows.net&#39; ([Errno -2] Name or service not known)&#34;))

View all 20 test failures

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 88.01%

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dacf57f | Docs | Datadog PR Page | Give us feedback!

@luisorofino luisorofino changed the title Remove extra_init_kwargs and implement Phase.build() Replace extra_init_kwargs with polymorphic Phase.build() factory and ResourceProvider Jun 1, 2026
@luisorofino luisorofino marked this pull request as ready for review June 1, 2026 12:23
@luisorofino luisorofino requested a review from a team as a code owner June 1, 2026 12:23
Copy link
Copy Markdown
Contributor Author

luisorofino commented Jun 3, 2026

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 3, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant