Set helper container resource limits for Guaranteed QoS on profiling tests#3672
Open
desponda wants to merge 1 commit intoDataDog:masterfrom
Open
Set helper container resource limits for Guaranteed QoS on profiling tests#3672desponda wants to merge 1 commit intoDataDog:masterfrom
desponda wants to merge 1 commit intoDataDog:masterfrom
Conversation
…tests The shared runner pool defaults leave helper container limits unset, causing pods to be Burstable QoS even when the build container has matching requests and limits. This adds explicit helper container resource limits (requests == limits) so the pod achieves Guaranteed QoS class, ensuring proper CPU cgroup enforcement. This fixes the issue where nproc reports the node's full CPU count (e.g. 66) instead of the requested 3 CPUs.
Author
|
/ddci trigger |
|
View all feedbacks in Devflow UI.
404 Not Found DetailsIf you need support, contact us on Slack #devflow with those details! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
substitutions.bzlin dd-source sets{helpers.cpuLimit}and{helpers.memoryLimit}to empty strings)KUBERNETES_CPU_REQUEST == KUBERNETES_CPU_LIMIT)KUBERNETES_HELPER_CPU_LIMITandKUBERNETES_HELPER_MEMORY_LIMIT(matching the existing requests of cpu: 1, memory: 2Gi) so all containers have requests == limits → Guaranteed QoSImpact
nprocreports the node's full CPU count (e.g. 66) instead of the requested 3 CPUs, which causes tools to spawn too many parallel jobsTest plan
qosClass: Guaranteedin the pod specnprocreports the correct CPU count (3) instead of the node's total🤖 Generated with Claude Code