Skip to content

Comments

ci(profiling): helper container resource limits#3673

Merged
morrisonlevi merged 1 commit intomasterfrom
levi/fix-profiler-qos-guaranteed
Feb 25, 2026
Merged

ci(profiling): helper container resource limits#3673
morrisonlevi merged 1 commit intomasterfrom
levi/fix-profiler-qos-guaranteed

Conversation

@morrisonlevi
Copy link
Collaborator

Description

Alternative PR to #3672 so that CI will run. Also added documentation into the file directly. Thanks Daniel!

The shared runner pool defaults leave helper container limits unset, causing pods to be Burstable QoS even when the build container has matching requests and limits. This adds explicit helper container resource limits (requests == limits) so the pod achieves Guaranteed QoS class, ensuring proper CPU cgroup enforcement.

This fixes the issue where nproc reports the node's full CPU count (e.g. 66) instead of the requested 3 CPUs.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

The shared runner pool defaults leave helper container limits unset,
causing pods to be Burstable QoS even when the build container has
matching requests and limits. This adds explicit helper container
resource limits (requests == limits) so the pod achieves Guaranteed
QoS class, ensuring proper CPU cgroup enforcement.

This fixes the issue where nproc reports the node's full CPU count
(e.g. 66) instead of the requested 3 CPUs.

Co-authored-by: Daniel Esponda <daniel.esponda@datadoghq.com>
@morrisonlevi morrisonlevi requested a review from a team as a code owner February 24, 2026 21:46
@datadog-datadog-prod-us1-2
Copy link

datadog-datadog-prod-us1-2 bot commented Feb 24, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 699e1bab00000000423ffcde9a8af6af
tid: 699e1bab00000000
hexProcessTraceId: 423ffcde9a8af6af
hexProcessSpanId: 23dc62bf69538b90
processTraceId: 4773812163041752751
processSpanId: 2584048860449180560

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 699e1be6000000003be182036b44fa35
tid: 699e1be600000000
hexProcessTraceId: 3be182036b44fa35
hexProcessSpanId: b71f3c68fedbca8f
processTraceId: 4314872869193841205
processSpanId: 13195331854868925071

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b337d72 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Feb 24, 2026
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Reviewed in-person with Levi, LGTM

@morrisonlevi morrisonlevi merged commit 55cce7c into master Feb 25, 2026
2048 of 2072 checks passed
@morrisonlevi morrisonlevi deleted the levi/fix-profiler-qos-guaranteed branch February 25, 2026 08:36
@github-actions github-actions bot added this to the 1.17.0 milestone Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants